remove pin on jsonpath-ng and fix issue #2
Conversation
dominikschubert
left a comment
dominikschubert
left a comment
There was a problem hiding this comment.
LGTM, thanks for unpinning 🥳
|
How do we proceed for this library? Do we need to update the version, anything to release so that it's effective in your PR? |
|
(tests were green in community with the fix and the unpinned dependency btw: localstack/localstack#10213) |
|
Imho there's no hurry to get this in a release. We can just remove the upper version pin in |
3 participants
We had to pin
jsonpath-ngto 1.5.3 following an update from the library. The following line from the change log is responsible:Basically, the matched path was returned with quotes when accessing from
match.full_pathormatch.path, which lead to issue in matching.We manually remove the
'from the field in order to have the same behavior as before.Example from
test_dot_in_skip_verification_path:Skipped paths:
["$..aab", "$..b.'a.aa'"]Matching the fields for
"$..b.'a.aa'"Before the fix:
1.5.3/ match full path =key_a.b.a.aa/ return value frombuild_full_path_nodes=["key_a", "b", "a.aa"]>1.6/ match full path =key_a.b.'a.aa'/ return value frombuild_full_path_nodes=["key_a", "b", "'a.aa'"]I believe we now could also use a regex instead of the whole
build_full_path_nodes, which would basically split on.not being enclosed in', but my regex knowledge is lacking 😬This simple fix will allow us to unpin for now.