Skip to content

Add AWS SDK v2 sync clients to TestUtils #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
whummer merged 1 commit into from
Jul 14, 2022
Merged

Add AWS SDK v2 sync clients to TestUtils #93

whummer merged 1 commit into from
Jul 14, 2022

Conversation

@scubasau
Copy link
Contributor

@scubasau scubasau commented May 11, 2022

Adds sync versions of the AWS SDK v2 SyncClients available in TestUtils to address issue #51
Tests in BasicFeaturesSDKV2Test have been extended to test both the async and sync clients.

whummer
whummer approved these changes Jul 14, 2022
View reviewed changes
Copy link
Member

@whummer whummer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @scubasau , apologies for the long delay on this one. Thanks for these changes, this is looking great! 👍 We'll get a new version deployed to Maven Central shortly..

@whummer whummer merged commit 1f5b540 into localstack:master Jul 14, 2022
@alexrashed alexrashed mentioned this pull request Jul 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@whummer whummer whummer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@scubasau @whummer