Skip to content

Conversation

@pinzon
Copy link
Member

@pinzon pinzon commented Mar 11, 2022

This PR adds some tests to validate issue localstack/localstack#5558.

@whummer
Copy link
Member

whummer commented Jul 14, 2022

Hi @pinzon , can you please rebase the PR and resolve the conflicts, so we can get this merged? Thanks!

@pinzon pinzon force-pushed the test_s3_object_deletion branch from 96f9521 to a7cba3d Compare July 14, 2022 16:27
@pinzon pinzon requested a review from whummer July 14, 2022 19:29
@whummer
Copy link
Member

whummer commented Jul 25, 2022

Hi @pinzon , sorry for the ping one more time ;) - the tests on master have now been fixed, can you please rebase the branch one more time, to get the builds green? Thx!

@pinzon pinzon force-pushed the test_s3_object_deletion branch from a7cba3d to 9428fac Compare July 25, 2022 14:09
@pinzon
Copy link
Member Author

pinzon commented Jul 25, 2022

@whummer of course, no problem!

Copy link
Member

@whummer whummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@whummer whummer merged commit 99435ef into localstack:master Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants