Skip to content

fix S3 endpoints #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bentsku merged 2 commits into from
Mar 31, 2023
Merged

fix S3 endpoints #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81bf393
fix S3 endpoints
bentsku Mar 30, 2023
1344b4d
bump version
bentsku Mar 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ Simply add the following dependency to your `pom.xml` file:
<dependency>
<groupId>cloud.localstack</groupId>
<artifactId>localstack-utils</artifactId>
<version>0.2.22</version>
<version>0.2.23</version>
</dependency>
```

Expand Down Expand Up @@ -112,6 +112,7 @@ To publish a release of the library, the "Maven Release" Github Action can be ma

## Change Log

* v0.2.23: Fix S3 endpoints to be compatible with LocalStack v2
* v0.2.22: Fix sqs event mapping for new event format, some test fixes
* v0.2.21: Bump version of AWS SDK v1; add AWS SDK v2 sync clients to TestUtils; add docker executable path under homebrew
* v0.2.20: Fix extracting container logs for LocalStack startup check
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<groupId>cloud.localstack</groupId>
<artifactId>localstack-utils</artifactId>
<packaging>jar</packaging>
<version>0.2.22</version>
<version>0.2.23</version>
<name>localstack-utils</name>

<description>Java utilities for the LocalStack platform.</description>
Expand Down
2 changes: 2 additions & 0 deletions src/main/java/cloud/localstack/Constants.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ public class Constants {

public static final String LOCALHOST_DOMAIN_NAME = "localhost.localstack.cloud";

public static final String S3_LOCALHOST_DOMAIN_NAME = "s3.localhost.localstack.cloud";

public static final String DEFAULT_AWS_ACCOUNT_ID = "000000000000";

public static final String ENV_LOCALSTACK_API_KEY = "LOCALSTACK_API_KEY";
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/cloud/localstack/Localstack.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ public String getEndpointS3() {
* <bucket-name>.localhost, but that name cannot be resolved (unless hardcoded
* in /etc/hosts)
*/
s3Endpoint = s3Endpoint.replace("localhost", Constants.LOCALHOST_DOMAIN_NAME);
s3Endpoint = s3Endpoint.replace("localhost", Constants.S3_LOCALHOST_DOMAIN_NAME);
return s3Endpoint;
}

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/cloud/localstack/deprecated/Localstack.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ public static String getEndpointS3(boolean overrideSSL) {
* which by default would result in <bucket-name>.localhost, but that name cannot be resolved
* (unless hardcoded in /etc/hosts)
*/
s3Endpoint = s3Endpoint.replace("localhost", Constants.LOCALHOST_DOMAIN_NAME);
s3Endpoint = s3Endpoint.replace("localhost", Constants.S3_LOCALHOST_DOMAIN_NAME);
return s3Endpoint;
}

Expand Down