fix S3 endpoints #102
Merged
fix S3 endpoints #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whummer
approved these changes
Mar 31, 2023
Member
whummer
left a comment
whummer
left a comment
There was a problem hiding this comment.
Great catch @bentsku ! Can you please also bump the version in pom.xml, and add a short entry to the change log in the README. 👍
We can then use the Maven release action to push a new release to Maven Central (hope the action still works): https://github.com/localstack/localstack-java-utils/actions/workflows/release.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the S3 endpoints to use
s3.localhost.localstack.cloud:4566instead oflocalhost.localstack.cloud:4566which doesn't support virtual host addressingthis should address localstack/localstack#8018