Merged
Conversation
simonrw
added
the
semver: patch
LocalStack Community integration with Pro 2 files 2 suites 1h 18m 21s ⏱️ Results for commit 2af4b6e. ♻️ This comment has been updated with latest results. |
dfangl
requested changes
Jan 3, 2024
Member
dfangl
left a comment
dfangl
left a comment
There was a problem hiding this comment.
I think this can help us significantly, but we need to make the streams cancellable, to avoid resource leaks.
Comment on lines
439
to
454
| for msg in CancellableProcessStream(process): | ||
| try: | ||
| yield json.loads(msg) | ||
| except json.JSONDecodeError as e: | ||
| LOG.warning("Error decoding docker event %s: %s", msg, e) | ||
|
|
Member
There was a problem hiding this comment.
Not sure about this. The stream is not cancellable with this construct. I think for these method we should always use a CancellableStream, so we can cancel it if necessary.
simonrw
force-pushed
the
docker/add-events-method
branch
from
c44f20e to
1f3ad85
Compare
simonrw
force-pushed
the
docker/add-events-method
branch
from
1f3ad85 to
2af4b6e
Compare
dfangl
approved these changes
Jan 5, 2024
dfangl
added a commit
that referenced
this pull request
Jan 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
For an upcoming change to the way containers are handled, we will want to be able to capture the docker events in order to properly handle notifications of container termination or shutdown.
Changes
This PR adds an
eventsmethod, which returns a generator of the events from the docker daemon.