Conversation
bentsku
added
aws:s3
LocalStack Community integration with Pro 2 files ± 0 2 suites ±0 1h 7m 49s ⏱️ -4s Results for commit f6e2fa0. ± Comparison against base commit f241251. This pull request removes 2 and adds 12 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
bentsku
force-pushed
the
add-s3-control
branch
from
5de016b to
f6e2fa0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently fully implemented in Moto, it would be easier to have it native for better compatibility with the S3 v3 provider. It would also allow us to support Access Point in the v3 provider (Moto just added partial support, but it's not fully in parity with AWS).
This is a pretty small provider, we can aim for same features as Moto for now.
Implementation of S3 Access Point compatibility will come in a next PR.
Resources:
Changes
Operations to implement (currently implemented in Moto):
PutPublicAccessBlockGetPublicAccessBlockDeletePublicAccessBlockCreateAccessPointGetAccessPointListAccessPoints(still need pagination)DeleteAccessPointPutAccessPointPolicyDeleteAccessPointPolicyGetAccessPointPolicyGetAccessPointPolicyStatusOf course, S3Control is also very weird with the
rest-xmlprotocol, and it needs its own serializer for now. 🙄 and some specs patches as well.