Skip to content

Conversation

@giograno
Copy link
Member

@giograno giograno commented Nov 8, 2023

Motivation

With the removal of the legacy lambda provider (#9543), we can now remove the obsolete aws_models.Component class and all its subclasses.

Changes

  • Removed localstack.utils.aws.aws_models.py with all the Component classes;
  • Briefly adapted the logic to create a kinesis stream.

@giograno giograno added the semver: patch Non-breaking changes which can be included in patch releases label Nov 8, 2023
@github-actions
Copy link

github-actions bot commented Nov 8, 2023

LocalStack Community integration with Pro

       2 files  ±0         2 suites  ±0   1h 5m 47s ⏱️ - 7m 53s
2 307 tests ±0  2 011 ✔️ ±0  296 💤 ±0  0 ±0 
2 308 runs  ±0  2 011 ✔️ ±0  297 💤 ±0  0 ±0 

Results for commit 37815c2. ± Comparison against base commit 45b80ca.

♻️ This comment has been updated with latest results.

@giograno giograno force-pushed the remove-obsolete-components branch from b4fc04b to 8652a9f Compare November 9, 2023 07:29
@giograno giograno changed the base branch from master to release/v3.0 November 9, 2023 07:30
@giograno giograno changed the title remove obsolete components remove obsolete aws components Nov 9, 2023
@giograno giograno requested a review from joe4dev November 9, 2023 07:33
@giograno giograno force-pushed the remove-obsolete-components branch from 8652a9f to 37815c2 Compare November 9, 2023 07:34
@giograno giograno added this to the 3.0 milestone Nov 9, 2023
@giograno giograno marked this pull request as ready for review November 9, 2023 07:36
Copy link
Member

@viren-nadkarni viren-nadkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔️

@coveralls
Copy link

Coverage Status

coverage: 83.886% (+0.1%) from 83.779%
when pulling 37815c2 on remove-obsolete-components
into 45b80ca on release/v3.0.

@giograno giograno merged commit 27a9480 into release/v3.0 Nov 9, 2023
@giograno giograno deleted the remove-obsolete-components branch November 9, 2023 09:43
@alexrashed alexrashed mentioned this pull request Nov 9, 2023
20 tasks
alexrashed pushed a commit that referenced this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants