Add fallback partition config option for ARN partition rewriter #9482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viren-nadkarni
added
semver: patch
viren-nadkarni
force-pushed
the
arn-part-rewrite-fallback
branch
from
a5894b6 to
ece27e4
Compare
viren-nadkarni
added
the
semver: major
Contributor
|
Currently, only minor and patch changes are allowed on master. Your PR labels (semver: major) indicate that it cannot be merged into the master at this time. |
viren-nadkarni
force-pushed
the
arn-part-rewrite-fallback
branch
from
ece27e4 to
0a317eb
Compare
viren-nadkarni
changed the title
localstack-bot
force-pushed
the
release/v3.0
branch
from
c97ddc3 to
85abf31
Compare
localstack-bot
requested review from
bentsku,
dfangl,
dominikschubert and
macnev2013
as code owners
viren-nadkarni
force-pushed
the
arn-part-rewrite-fallback
branch
from
0a317eb to
451a0b2
Compare
viren-nadkarni
force-pushed
the
arn-part-rewrite-fallback
branch
from
451a0b2 to
54d03f9
Compare
viren-nadkarni
removed request for
bentsku,
dfangl,
dominikschubert and
macnev2013
alexrashed
approved these changes
Oct 27, 2023
Member
alexrashed
left a comment
alexrashed
left a comment
There was a problem hiding this comment.
Thanks! The code is nice and clean! Thanks for addressing this in order to finally be able to remove the DEFAULT_REGION. 🚀 🧹
alexrashed
pushed a commit
that referenced
this pull request
Oct 28, 2023
localstack-bot
pushed a commit
that referenced
this pull request
Oct 31, 2023
alexrashed
pushed a commit
that referenced
this pull request
Oct 31, 2023
alexrashed
pushed a commit
that referenced
this pull request
Nov 1, 2023
alexrashed
pushed a commit
that referenced
this pull request
Nov 1, 2023
alexrashed
pushed a commit
that referenced
this pull request
Nov 1, 2023
alexrashed
pushed a commit
that referenced
this pull request
Nov 1, 2023
alexrashed
pushed a commit
that referenced
this pull request
Nov 2, 2023
alexrashed
pushed a commit
that referenced
this pull request
Nov 2, 2023
alexrashed
pushed a commit
that referenced
this pull request
Nov 2, 2023
alexrashed
pushed a commit
that referenced
this pull request
Nov 2, 2023
localstack-bot
pushed a commit
that referenced
this pull request
Nov 3, 2023
alexrashed
pushed a commit
that referenced
this pull request
Nov 3, 2023
alexrashed
pushed a commit
that referenced
this pull request
Nov 4, 2023
localstack-bot
pushed a commit
that referenced
this pull request
Nov 7, 2023
alexrashed
pushed a commit
that referenced
this pull request
Nov 7, 2023
alexrashed
pushed a commit
that referenced
this pull request
Nov 7, 2023
localstack-bot
pushed a commit
that referenced
this pull request
Nov 9, 2023
alexrashed
pushed a commit
that referenced
this pull request
Nov 9, 2023
alexrashed
pushed a commit
that referenced
this pull request
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The ARN partition rewriter depends on the deprecated environment config variable
DEFAULT_REGION. It uses this to determine which partition to use as a fallback.This is preventing us from removing the
DEFAULT_REGIONconfig option with the upcoming major release.Implementation
This PR introduces a new config option
ARN_PARTITION_FALLBACKwhich can be used to set which partition to use as fallback. It defaults toaws, which is identical to old behaviour where it would be determined from theus-east-1region.The
DEFAULT_REGIONconfig option will no longer have any effect on the rewriter.Acceptance of this PR will entail an update to enterprise image build steps.
Tests
Slightly tweaks existing tests to assert the new behaviour.