Rename default container name to localstack-main #9469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonrw
added
the
semver: major
localstack-bot
force-pushed
the
release/v3.0
branch
2 times, most recently
from
c97ddc3 to
85abf31
Compare
simonrw
force-pushed
the
major/rename-default-container-name
branch
from
b103bc3 to
383295d
Compare
alexrashed
force-pushed
the
release/v3.0
branch
from
76f2a3e to
de35cb0
Compare
simonrw
force-pushed
the
major/rename-default-container-name
branch
from
383295d to
2222acc
Compare
localstack-bot
force-pushed
the
release/v3.0
branch
from
de35cb0 to
71c00c3
Compare
alexrashed
force-pushed
the
release/v3.0
branch
from
71c00c3 to
8c937c6
Compare
simonrw
requested review from
HarshCasper,
alexrashed,
baermat,
bentsku,
calvernaz,
dfangl,
dominikschubert,
macnev2013,
sannya-singal,
silv-io,
steffyP and
thrau
as code owners
simonrw
removed request for
calvernaz,
dominikschubert,
macnev2013,
silv-io,
steffyP and
thrau
simonrw
force-pushed
the
major/rename-default-container-name
branch
from
ebaccf6 to
8bc385a
Compare
This was referenced Nov 2, 2023
Merged
localstack-bot
pushed a commit
that referenced
this pull request
Nov 3, 2023
alexrashed
pushed a commit
that referenced
this pull request
Nov 3, 2023
simonrw
added a commit
to localstack/localstack-demo
that referenced
this pull request
Nov 3, 2023
The previous default container name `localstack_main` is not a valid URL, so we rename the default to `localstack-main`. See localstack/localstack#9469.
simonrw
added a commit
to localstack/localstack-java-utils
that referenced
this pull request
Nov 3, 2023
The previous default container name `localstack_main` is not a valid URL, so we rename the default to `localstack-main`. See localstack/localstack#9469.
simonrw
added a commit
to localstack-samples/localstack-pro-samples
that referenced
this pull request
Nov 3, 2023
The previous default container name `localstack_main` is not a valid URL, so we rename the default to `localstack-main`. See localstack/localstack#9469.
simonrw
added a commit
to localstack-samples/localstack-terraform-samples
that referenced
this pull request
Nov 3, 2023
The previous default container name `localstack_main` is not a valid URL, so we rename the default to `localstack-main`. See localstack/localstack#9469.
alexrashed
pushed a commit
that referenced
this pull request
Nov 4, 2023
simonrw
added a commit
to localstack/docs
that referenced
this pull request
Nov 6, 2023
The previous default container name `localstack_main` is not a valid URL, so we rename the default to `localstack-main`. See localstack/localstack#9469.
simonrw
added a commit
to localstack/docs
that referenced
this pull request
Nov 6, 2023
The previous default container name `localstack_main` is not a valid URL, so we rename the default to `localstack-main`. See localstack/localstack#9469.
localstack-bot
pushed a commit
that referenced
this pull request
Nov 7, 2023
alexrashed
pushed a commit
that referenced
this pull request
Nov 7, 2023
alexrashed
pushed a commit
that referenced
this pull request
Nov 7, 2023
localstack-bot
pushed a commit
that referenced
this pull request
Nov 9, 2023
alexrashed
pushed a commit
to localstack/docs
that referenced
this pull request
Nov 9, 2023
The previous default container name `localstack_main` is not a valid URL, so we rename the default to `localstack-main`. See localstack/localstack#9469.
alexrashed
pushed a commit
that referenced
this pull request
Nov 9, 2023
alexrashed
pushed a commit
that referenced
this pull request
Nov 9, 2023
whummer
pushed a commit
to localstack/localstack-java-utils
that referenced
this pull request
Nov 15, 2023
The previous default container name `localstack_main` is not a valid URL, so we rename the default to `localstack-main`. See localstack/localstack#9469.
simonrw
added a commit
to localstack/localstack-demo
that referenced
this pull request
Nov 18, 2023
The previous default container name `localstack_main` is not a valid URL, so we rename the default to `localstack-main`. See localstack/localstack#9469.
simonrw
added a commit
to simonrw/sample-cdk-sqs-fargate-dynamodb
that referenced
this pull request
Nov 20, 2023
The previous default container name `localstack_main` is not a valid URL, so we rename the default to `localstack-main`. See localstack/localstack#9469.
simonrw
added a commit
to simonrw/sample-fuzzy-movie-search-lambda-kinesis-elasticsearch
that referenced
this pull request
Nov 20, 2023
The previous default container name `localstack_main` is not a valid URL, so we rename the default to `localstack-main`. See localstack/localstack#9469.
simonrw
added a commit
to simonrw/sample-query-data-s3-athena-glue
that referenced
this pull request
Nov 20, 2023
The previous default container name `localstack_main` is not a valid URL, so we rename the default to `localstack-main`. See localstack/localstack#9469.
HarshCasper
pushed a commit
to localstack-samples/localstack-pro-samples
that referenced
this pull request
Nov 23, 2023
The previous default container name `localstack_main` is not a valid URL, so we rename the default to `localstack-main`. See localstack/localstack#9469.
Ashoat
added a commit
to CommE2E/comm
that referenced
this pull request
Apr 4, 2024
Summary: When we updated localstack in [ENG-5724](https://linear.app/comm/issue/ENG-5724/investigate-updating-localstack), we pulled in [this change](localstack/localstack#9469). As a result `comm-dev services stop` stopped working because we had the wrong name for the Docker container. Test Plan: 1. Confirm that `comm-dev services stop` no longer prints the error "Error response from daemon: No such container: localstack_main" 2. Confirm that `comm-dev services start` following `comm-dev services stop` no longer prints the message "localstack is already running, skipping localstack initialization" Reviewers: bartek Subscribers:
Ashoat
added a commit
to CommE2E/comm
that referenced
this pull request
Apr 4, 2024
Summary: When we updated localstack in [ENG-5724](https://linear.app/comm/issue/ENG-5724/investigate-updating-localstack), we pulled in [this change](localstack/localstack#9469). As a result `comm-dev services stop` stopped working because we had the wrong name for the Docker container. Test Plan: 1. Confirm that `comm-dev services stop` no longer prints the error "Error response from daemon: No such container: localstack_main" 2. Confirm that `comm-dev services start` following `comm-dev services stop` no longer prints the message "localstack is already running, skipping localstack initialization" Reviewers: bartek Reviewed By: bartek Subscribers: tomek Differential Revision: https://phab.comm.dev/D11550
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Hyphens are not allowed in URLs. When addressing the LocalStack container over a docker network, the container name resolves to the IP address of the container. This is a problem in particular for
boto3which refuses to connect.Changes
Rename
localstack_main->localstack-main