This repository was archived by the owner on Mar 23, 2026. It is now read-only.
Integrate lambda init upstream changes#9378
Merged
Merged
Conversation
We also use this in other parts of the test suite. This also makes it easier to force executing tests on ARM machines by returning "x86_64" in `get_arch` rather than modifying many test conditions.
joe4dev
added
the
semver: minor
Member
Author
|
I kinda expected some failing tests after local testing but it appears these were mostly limitations of running on macOS and ARM 🥲 😎 Logging on default level didn't change (nit: was hoping to get rid of the first warning message "Cannot list external agents" but I guess we would need to create |
joe4dev
marked this pull request as ready for review
October 18, 2023 11:00
joe4dev
requested review from
dfangl,
dominikschubert and
steffyP
as code owners
October 18, 2023 11:00
dfangl
approved these changes
Oct 18, 2023
dfangl
left a comment
dfangl
left a comment
Member
There was a problem hiding this comment.
LGTM, we should fix the missing init duration soon though!
Member
Author
fully agree. Too bad we need to skip useful test snapshots just because of this missing parity. It should be quite easy because there are examples for the calculations; just need to tackle it :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on localstack/lambda-runtime-init#24
Motivation
The official AWS lambda-runtime-init received some upstream updates (typically merged in big blobs from their internal repository). We should update our customized localstack version to support the latest features (e.g., response streaming) and updates (e.g., the new Golang version).
See localstack/lambda-runtime-init#24
Changes
request_idtest to cover a regression where the ID didn't matchlambda_report_logstransformersget_archTesting
See localstack/lambda-runtime-init#24
TODO