Remove deprecated config DEFAULT_REGION #9375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viren-nadkarni
added
the
semver: major
Contributor
|
Currently, only minor and patch changes are allowed on master. Your PR labels (semver: major) indicate that it cannot be merged into the master at this time. |
viren-nadkarni
force-pushed
the
remove-default-region
branch
2 times, most recently
from
5606482 to
d4b8bc1
Compare
viren-nadkarni
requested review from
baermat,
bentsku,
calvernaz,
dominikschubert,
macnev2013,
sannya-singal,
silv-io,
steffyP and
thrau
as code owners
viren-nadkarni
requested review from
alexrashed
and removed request for
baermat,
bentsku,
calvernaz,
dominikschubert,
macnev2013,
sannya-singal,
silv-io,
steffyP and
thrau
alexrashed
requested changes
Oct 24, 2023
Member
alexrashed
left a comment
alexrashed
left a comment
There was a problem hiding this comment.
I am glad we are finally trying to get rid of the DEFAULT_REGION.
Unfortunately, it seems that we have to find an alternative for the ARN partition rewriting...
Besides that, I only found some minor things (like that we should still warn the user that they are using a variable that doesn't have an effect anymore)...
localstack-bot
force-pushed
the
release/v3.0
branch
from
a17da70 to
c97ddc3
Compare
viren-nadkarni
force-pushed
the
remove-default-region
branch
from
f0905dd to
05b0c1b
Compare
alexrashed
approved these changes
Oct 27, 2023
Member
alexrashed
left a comment
alexrashed
left a comment
There was a problem hiding this comment.
Thanks for addressing the comments, and cleaning up all the usages! This is a great step forward with the multi-region support, and to make sure that the region is properly handled for all requests. 🚀
alexrashed
pushed a commit
that referenced
this pull request
Oct 28, 2023
localstack-bot
pushed a commit
that referenced
this pull request
Oct 31, 2023
alexrashed
pushed a commit
that referenced
this pull request
Oct 31, 2023
alexrashed
pushed a commit
that referenced
this pull request
Nov 1, 2023
alexrashed
pushed a commit
that referenced
this pull request
Nov 1, 2023
alexrashed
pushed a commit
that referenced
this pull request
Nov 1, 2023
alexrashed
pushed a commit
that referenced
this pull request
Nov 1, 2023
alexrashed
pushed a commit
that referenced
this pull request
Nov 2, 2023
alexrashed
pushed a commit
that referenced
this pull request
Nov 2, 2023
alexrashed
pushed a commit
that referenced
this pull request
Nov 2, 2023
alexrashed
pushed a commit
that referenced
this pull request
Nov 2, 2023
alexrashed
pushed a commit
that referenced
this pull request
Nov 2, 2023
localstack-bot
pushed a commit
that referenced
this pull request
Nov 3, 2023
alexrashed
pushed a commit
that referenced
this pull request
Nov 3, 2023
alexrashed
pushed a commit
that referenced
this pull request
Nov 4, 2023
joe4dev
pushed a commit
that referenced
this pull request
Nov 6, 2023
joe4dev
pushed a commit
that referenced
this pull request
Nov 6, 2023
joe4dev
pushed a commit
that referenced
this pull request
Nov 6, 2023
localstack-bot
pushed a commit
that referenced
this pull request
Nov 7, 2023
alexrashed
pushed a commit
that referenced
this pull request
Nov 7, 2023
alexrashed
pushed a commit
that referenced
this pull request
Nov 7, 2023
localstack-bot
pushed a commit
that referenced
this pull request
Nov 9, 2023
alexrashed
pushed a commit
that referenced
this pull request
Nov 9, 2023
alexrashed
pushed a commit
that referenced
this pull request
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
DEFAULT_REGIONenvironment config variable was used in early years of LocalStack when multi-region was unsupported. It has since been deprecated.This PR removes this config variable for the upcoming major release.