Skip to content

implement S3 native BucketLogging and BucketReplication #8901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bentsku merged 3 commits into from
Aug 16, 2023
Merged

implement S3 native BucketLogging and BucketReplication #8901

bentsku merged 3 commits into from
Aug 16, 2023

Conversation

@bentsku
Copy link
Contributor

@bentsku bentsku commented Aug 13, 2023 •
edited
Loading

Motivation

Implement S3 BucketLogging and BucketReplication mocking, only adding validation but not actually emulating the replication.

Changes

Added a small fix regarding locking when accessing a Multipart, to not create it twice.
Implemented the following API operations:

  • PutBucketLogging
  • GetBucketLogging
  • PutBucketReplication
  • GetBucketReplication
  • DeleteBucketReplication

@bentsku bentsku added aws:s3 Amazon Simple Storage Service semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases labels Aug 13, 2023
@bentsku bentsku self-assigned this Aug 13, 2023
@bentsku bentsku changed the base branch from master to s3-native-policy-accelerate August 13, 2023 00:45
@bentsku bentsku changed the title implement S3 native BucketPolicy and BucketReplication implement S3 native BucketLogging and BucketReplication Aug 13, 2023
@bentsku bentsku mentioned this pull request Aug 13, 2023
Merged
@coveralls
Copy link

coveralls commented Aug 13, 2023

Coverage Status

coverage: 80.885% (-0.05%) from 80.937% when pulling 241be74 on s3-native-policy-replication into ce7e200 on s3-native-policy-accelerate.

@bentsku bentsku force-pushed the s3-native-policy-accelerate branch from ce7e200 to 7e41233 Compare August 15, 2023 21:16
@bentsku bentsku force-pushed the s3-native-policy-replication branch from 241be74 to db3f515 Compare August 15, 2023 21:18
@bentsku bentsku marked this pull request as ready for review August 15, 2023 21:27
@bentsku bentsku requested a review from macnev2013 as a code owner August 15, 2023 21:27
macnev2013
macnev2013 approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@macnev2013 macnev2013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@bentsku bentsku force-pushed the s3-native-policy-accelerate branch from 7e41233 to abd2208 Compare August 16, 2023 12:38
@bentsku bentsku requested a review from thrau as a code owner August 16, 2023 12:38
Base automatically changed from s3-native-policy-accelerate to master August 16, 2023 14:29
@bentsku bentsku force-pushed the s3-native-policy-replication branch from db3f515 to a3af01c Compare August 16, 2023 15:14
@thrau thrau removed their request for review August 16, 2023 15:25
@github-actions
Copy link

github-actions bot commented Aug 16, 2023

LocalStack Community integration with Pro

       2 files         2 suites   1h 20m 30s ⏱️
2 084 tests 1 658 ✔️ 426 💤 0 ❌
2 085 runs  1 658 ✔️ 427 💤 0 ❌

Results for commit a3af01c.

@bentsku bentsku merged commit 555f8da into master Aug 16, 2023
@bentsku bentsku deleted the s3-native-policy-replication branch August 16, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@macnev2013 macnev2013 macnev2013 approved these changes

Assignees

@bentsku bentsku

Labels

aws:s3 Amazon Simple Storage Service semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bentsku @coveralls @macnev2013