Skip to content

implement S3 native Bucket Policy and AccelerateConfig #8889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bentsku merged 2 commits into from
Aug 16, 2023
Merged

implement S3 native Bucket Policy and AccelerateConfig #8889

bentsku merged 2 commits into from
Aug 16, 2023

Conversation

@bentsku
Copy link
Contributor

@bentsku bentsku commented Aug 10, 2023 •
edited
Loading

Motivation

This PR implements the BucketPolicy and BucketAccelerateConfiguration to the new S3 provider.

Changes

Those operations were only implemented in moto. Added a tiny bit of validation for the Bucket Policy, but we should/could go a bit further.
Implemented operations:

  • PutBucketPolicy
  • GetPolicyPolicy
  • DeletePolicyPolicy
  • GetBucketAccelerateConfiguration
  • PutBucketAccelerateConfiguration

@bentsku bentsku added aws:s3 Amazon Simple Storage Service semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases labels Aug 10, 2023
@bentsku bentsku self-assigned this Aug 10, 2023
@bentsku bentsku mentioned this pull request Aug 10, 2023
Merged
@bentsku bentsku changed the base branch from master to s3-native-access-block-ownership August 10, 2023 16:46
@coveralls
Copy link

coveralls commented Aug 10, 2023 •
edited
Loading

Coverage Status

coverage: 80.937% (-0.009%) from 80.946% when pulling ce7e200 on s3-native-policy-accelerate into 72738a3 on s3-native-access-block-ownership.

@github-actions
Copy link

github-actions bot commented Aug 10, 2023 •
edited
Loading

LocalStack Community integration with Pro

       2 files         2 suites   1h 23m 50s ⏱️
2 084 tests 1 658 ✔️ 426 💤 0 ❌
2 085 runs  1 658 ✔️ 427 💤 0 ❌

Results for commit abd2208.

♻️ This comment has been updated with latest results.

@bentsku bentsku force-pushed the s3-native-policy-accelerate branch from 25b8d89 to ce7e200 Compare August 13, 2023 00:41
@bentsku bentsku force-pushed the s3-native-access-block-ownership branch 2 times, most recently from ea55b5a to 8f4f6cb Compare August 15, 2023 21:14
@bentsku bentsku force-pushed the s3-native-policy-accelerate branch from ce7e200 to 7e41233 Compare August 15, 2023 21:16
@bentsku bentsku marked this pull request as ready for review August 15, 2023 21:27
thrau
thrau approved these changes Aug 15, 2023
View reviewed changes
Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

macnev2013
macnev2013 approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@macnev2013 macnev2013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from s3-native-access-block-ownership to master August 16, 2023 12:36
@bentsku bentsku force-pushed the s3-native-policy-accelerate branch from 7e41233 to abd2208 Compare August 16, 2023 12:38
@bentsku bentsku merged commit 1ddc8c5 into master Aug 16, 2023
@bentsku bentsku deleted the s3-native-policy-accelerate branch August 16, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thrau thrau thrau approved these changes

@macnev2013 macnev2013 macnev2013 approved these changes

Assignees

@bentsku bentsku

Labels

aws:s3 Amazon Simple Storage Service semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bentsku @coveralls @thrau @macnev2013