-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
make new s3 v3 provider default #8785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b6c5246 to
2c9e482
Compare
9a3988c to
596f6df
Compare
|
Update: around 60 tests are still failing on 23/09/10, mostly related to pre-signed URLs |
a265619 to
d758d94
Compare
|
Update: only 1 or 2 tests are failing:
edit: this was due to some wrong logic in the storage layer, this should now be fixed 🎉 |
5ca1c2d to
d6c9525
Compare
8bde1ac to
3545e7e
Compare
19c8422 to
6ff5c4c
Compare
ef5eb95 to
3fcbb2a
Compare
6dd6b1b to
7b9e2b4
Compare
7defab6 to
8d09b49
Compare
7b9e2b4 to
e77b647
Compare
18da430 to
a966604
Compare
fb5da7d to
99278b3
Compare
a966604 to
b6a5649
Compare
alexrashed
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Really great to see the native provider becoming the default! 🚀 🧹
Motivation
This PR will make the new s3 v3 provider default for the new 3.0 release.
Changes
Make the new provider default, create a new
legacy_v2provider for S3 for us to advertise instead ofv2orasfwhich don't communicate well the fact that it's the previous implementation.Remove checks for
NATIVE_PROVIDERas it's now default, and invert the checks.Add a warning if people are still using
v2.Updated the CI job to test legacy v2, we can keep until the release of
3.1to ensure stability and visibility into moto changes.Note: sorry for the changes once again in the tests conditions, I missed this change in the removal of the legacy code.
Contained PRs (30):
Incoming PRs: