Skip to content

Fix local execution of java lambdas if handler method is implementing RequestHandler interface #4849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dfangl merged 2 commits into from
Nov 3, 2021
Merged

Fix local execution of java lambdas if handler method is implementing RequestHandler interface #4849

dfangl merged 2 commits into from
Nov 3, 2021

Conversation

@dfangl
Copy link
Member

@dfangl dfangl commented Nov 3, 2021

Issue was due to type erasure and creation of bridge functions in Java.

Fixes #4512.

To be released after artifacts of localstack/localstack-java-utils#79 are published.

@dfangl
bump localstack-java-utils version to 0.2.17, add test for specifying…
1ca7b09 
… java handler method which implements a generic interface like RequestHandler
@dfangl dfangl temporarily deployed to localstack-ext-tests November 3, 2021 14:58 Inactive
@dfangl dfangl requested a review from whummer November 3, 2021 14:59
whummer
whummer approved these changes Nov 3, 2021
View reviewed changes
Copy link
Member

@whummer whummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @dfangl ! 🎉 Version 0.2.17 of Java utils is now released on Maven Central.. 👍

@github-actions
Copy link

github-actions bot commented Nov 3, 2021 •
edited
Loading

LocalStack integration with Pro

    1 files  ±0      1 suites  ±0   16m 56s ⏱️ - 2m 14s
639 tests +2  614 ✔️ +2  17 💤 ±0  8 ❌ ±0 

For more details on these failures, see this check.

Results for commit 7e8eacb. ± Comparison against base commit cb2f6a4.

This pull request removes 1 and adds 3 tests. Note that renamed tests count towards both. 
tests.integration.test_lambda ‑ test_java_custom_handler_method_specification

tests.integration.test_lambda ‑ test_java_custom_handler_method_specification[cloud.localstack.sample.LambdaHandlerWithInterfaceAndCustom-INTERFACE]
tests.integration.test_lambda ‑ test_java_custom_handler_method_specification[cloud.localstack.sample.LambdaHandlerWithInterfaceAndCustom::handleRequest-INTERFACE]
tests.integration.test_lambda ‑ test_java_custom_handler_method_specification[cloud.localstack.sample.LambdaHandlerWithInterfaceAndCustom::handleRequestCustom-CUSTOM]

♻️ This comment has been updated with latest results.

@dfangl dfangl temporarily deployed to localstack-ext-tests November 3, 2021 15:31 Inactive
@coveralls
Copy link

coveralls commented Nov 3, 2021

Coverage Status

Coverage increased (+0.2%) to 80.587% when pulling 7e8eacb on bugfix/java-lambda-local-execution into cb2f6a4 on master.

@dfangl dfangl merged commit 436f129 into master Nov 3, 2021
@dfangl dfangl deleted the bugfix/java-lambda-local-execution branch November 3, 2021 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@whummer whummer whummer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: Java 11 Lambda incorrect handler specification

4 participants

@dfangl @coveralls @whummer