add PERSISTENCE_SINGLE_FILE environment variable#3913
Merged
whummer merged 1 commit intolocalstack:masterfrom Apr 27, 2021
Merged
add PERSISTENCE_SINGLE_FILE environment variable#3913whummer merged 1 commit intolocalstack:masterfrom
whummer merged 1 commit intolocalstack:masterfrom
Conversation
whummer
reviewed
Apr 22, 2021
collinsauve
force-pushed
the
configure-single-dump-file
branch
from
f97bfcb to
6bb76e8
Compare
collinsauve
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
utils/persistence.pyalready has most of the code available to switch on this, it just is not exposed to be configured by an environment variable.I used the name as it stood. Since this name will be difficult to change once it's in place you may want to consider inverting this to
USE_MULTIPLE_DUMP_FILESwith the default offalse. If you'd like to change the name, happy to resubmit this PR :)