-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Fix: Fixing kinesis get-stream output when data is bytearray #3605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Great, thanks for digging into this issue @mgagliardo . Do you think we can add this test also to our Java library integration tests? Thanks! |
Member
|
@mgagliardo Just a quick note - is this something that appears only with AWS Java SDK v2, or also v1? Can we also verify that it is backwards compatible with v1? (We have tests for both v1 and v2 in the Java repo..) Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the data put into kinesis streams is put into an
SdkBytesbyte format and not standard bytes or base64 format it needs to be decoded. This PR fixes that issue.Fixes #3588
Steps to reproduce:
Java code:
src/main/java/com/test/PutDataExample.javapom.xml(I'm probably using more dependencies than expected):mvn clean compile assembly:singlejava -cp target/my-app-1.0-SNAPSHOT-jar-with-dependencies.jar com.test.PutDataExampleExample output: