#2131 Missing Message Subject at LambdaExecutor #2143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
duongpv7
commented
Mar 10, 2020
duongpv7
commented
- Fix lint error template_deployer.py
- Fix log steam name (That was an issue with get-log-events API)
- Add lambda integration test
- Create topic
- Create a lambda function that subscribe that topic
- Push an message with subject
- Get event message from cloudwatch logs to confirm subject exists in message event
* Fix lint error template_deployer.py * Fix log steam name (That was an issue with get-log-events api) * Add lambda integration test
whummer
reviewed
Mar 10, 2020
Member
whummer
left a comment
whummer
left a comment
There was a problem hiding this comment.
Looks great - only a few nitpick comments
* Minor fixes
* Fix error create lambda function in docker mode
* Remove lambda handler name (using default)
* Change handler function name
jgbmattos
pushed a commit
to jgbmattos/localstack
that referenced
this pull request
Mar 11, 2020
…ocalstack#2143) Add message polling mechanism for Lambda-SQS integration (localstack#2145)
jgbmattos
pushed a commit
to jgbmattos/localstack
that referenced
this pull request
Mar 11, 2020
…ocalstack#2143) Add message polling mechanism for Lambda-SQS integration (localstack#2145)
jgbmattos
pushed a commit
to jgbmattos/localstack
that referenced
this pull request
Mar 11, 2020
…2145) Added support to redrive policy on SNS product. It was necessary to change the lambda_api.process_sns_notification raise exception to the function caller and then handle the error for redrive policy work properly. add test to assert presence of message Subject in SNS Lambda events (localstack#2143) Add message polling mechanism for Lambda-SQS integration (localstack#2145)
jgbmattos
pushed a commit
to jgbmattos/localstack
that referenced
this pull request
Mar 11, 2020
…2145) Added support to redrive policy on SNS product. It was necessary to change the lambda_api.process_sns_notification raise exception to the function caller and then handle the error for redrive policy work properly. add test to assert presence of message Subject in SNS Lambda events (localstack#2143) Add message polling mechanism for Lambda-SQS integration (localstack#2145)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.