Skip to content

Configure nodejs Lambdas to skip SSL verification #2104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
whummer merged 2 commits into from
Feb 28, 2020
Merged

Configure nodejs Lambdas to skip SSL verification #2104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9277821
configure nodejs Lambdas to skip SSL verification
whummer Feb 28, 2020
739961f
add CF support for S3::BucketPolicy
whummer Feb 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions localstack/services/awslambda/lambda_executors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,11 @@ def is_java_lambda(lambda_details):
return runtime in [LAMBDA_RUNTIME_JAVA8, LAMBDA_RUNTIME_JAVA11]


def is_nodejs_runtime(lambda_details):
runtime = getattr(lambda_details, 'runtime', lambda_details)
return runtime.startswith('nodejs')


class LambdaExecutor(object):
""" Base class for Lambda executors. Subclasses must overwrite the _execute method """

Expand Down Expand Up @@ -229,6 +234,10 @@ def _execute(self, func_arn, func_details, event, context=None, version=None):
command = ("bash -c 'cd %s; java %s -cp \"%s\" \"%s\" \"%s\" \"%s\"'" %
(taskdir, java_opts, classpath, LAMBDA_EXECUTOR_CLASS, handler, LAMBDA_EVENT_FILE))

# accept any self-signed certificates for outgoing calls from the Lambda
if is_nodejs_runtime(runtime):
environment['NODE_TLS_REJECT_UNAUTHORIZED'] = '0'

# determine the command to be executed (implemented by subclasses)
cmd = self.prepare_execution(func_arn, environment, runtime, command, handler, lambda_cwd)

Expand Down
23 changes: 21 additions & 2 deletions localstack/utils/cloudformation/template_deployer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,15 @@ def lambda_get_params():
return lambda params, **kwargs: params


def rename_params(func, rename_map):
def do_rename(params, **kwargs):
values = func(params, **kwargs) if func else params
for old_param, new_param in rename_map.items():
values[new_param] = values.pop(old_param, None)
return values
return do_rename


def get_nested_stack_name(params, **kwargs):
stack_name = kwargs.get('stack_name', 'stack')
return '%s-%s' % (stack_name, common.short_uid())
Expand Down Expand Up @@ -84,9 +93,9 @@ def select_parameters(*param_names):
return lambda params, **kwargs: dict([(k, v) for k, v in params.items() if k in param_names])


def dump_json_params(param_func, *param_names):
def dump_json_params(param_func=None, *param_names):
def replace(params, **kwargs):
result = param_func(params, **kwargs)
result = param_func(params, **kwargs) if param_func else params
for name in param_names:
if isinstance(result.get(name), (dict, list)):
# Fix for https://github.com/localstack/localstack/issues/2022
Expand Down Expand Up @@ -125,6 +134,12 @@ def replace(params, **kwargs):
}
}
},
'S3::BucketPolicy': {
'create': {
'function': 'put_bucket_policy',
'parameters': rename_params(dump_json_params(None, 'PolicyDocument'), {'PolicyDocument': 'Policy'})
}
},
'SQS::Queue': {
'create': {
'function': 'create_queue',
Expand Down Expand Up @@ -592,6 +607,10 @@ def retrieve_resource_details(resource_id, resource_status, resources, stack_nam
bucket_name = resource_props.get('BucketName') or resource_id
bucket_name = resolve_refs_recursively(stack_name, bucket_name, resources)
return aws_stack.connect_to_service('s3').get_bucket_location(Bucket=bucket_name)
elif resource_type == 'S3::BucketPolicy':
bucket_name = resource_props.get('Bucket') or resource_id
bucket_name = resolve_refs_recursively(stack_name, bucket_name, resources)
return aws_stack.connect_to_service('s3').get_bucket_policy(Bucket=bucket_name)
elif resource_type == 'Logs::LogGroup':
# TODO implement
raise Exception('ResourceNotFound')
Expand Down