CFn: implement DeletionPolicy and UpdateReplacePolicy #13535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonrw
added
semver: patch
simonrw
force-pushed
the
cfn/handle-policies
branch
from
2e205bc to
7c41c83
Compare
Test Results - Alternative Providers587 tests 326 ✅ 17m 47s ⏱️ Results for commit f53ac96. ♻️ This comment has been updated with latest results. |
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 2h 34m 14s ⏱️ Results for commit f53ac96. ♻️ This comment has been updated with latest results. |
# Motivation A user has reported that setting policies is not only not implemented by our engigne, but actually incorrectly raises an error. # Changes * Don't raise error when modeling the policy fields * Skip deletion if `UpdateReplacePolicy=Retain` and a resource is updated * Skip deletion if `DeletionPolicy=Retain` and a resource is deleted # Related to Resolves ENG-200
simonrw
force-pushed
the
cfn/handle-policies
branch
from
7c41c83 to
f53ac96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
A user has reported that setting policies is not only not implemented by our engigne, but actually incorrectly raises an error.
Changes
UpdateReplacePolicy=Retainand a resource is updatedDeletionPolicy=Retainand a resource is deletedRelated to
Resolves ENG-200