CFn: validate Type is provided
#13524
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Motivation While discusing #13496 I asserted that we can safely access `resource["Type"]` in the visitors since we validate that the `Type` key is always present. However this _was not true_! This PR resolves this # Changes * Add test deploying resource without a `Type` key * Validate that the type is present during the modelling phase
simonrw
added
semver: patch
simonrw
added
notes: skip
LocalStack Community integration with Pro 2 files 2 suites 31m 9s ⏱️ Results for commit 2c735e7. ♻️ This comment has been updated with latest results. |
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 43m 27s ⏱️ Results for commit 2c735e7. ♻️ This comment has been updated with latest results. |
Test Results - Alternative Providers584 tests 325 ✅ 17m 41s ⏱️ Results for commit 2c735e7. ♻️ This comment has been updated with latest results. |
simonrw
force-pushed
the
cfn/required-types
branch
from
b70b887 to
2c735e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
While discusing #13496 I asserted that we can safely access
resource["Type"]in the visitors since we validate that theTypekey is always present. However this was not true! This PR resolves thisChanges
Typekey