Skip to content

Lambda: add validations for PublishTo and inexistent capacity provider #13519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
anisaoshafi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Lambda: add validations for PublishTo and inexistent capacity provider #13519

anisaoshafi wants to merge 1 commit into from

Conversation

@anisaoshafi
Copy link
Contributor

@anisaoshafi anisaoshafi commented Dec 12, 2025 •
edited by joe4dev
Loading

Motivation

Add validations for PublishTo and inexistent capacity provider for Lambda Managed Instances.

Changes

Tests

Related

Closes DRG-298

@anisaoshafi anisaoshafi added aws:lambda AWS Lambda semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Dec 12, 2025
@github-actions
Copy link

github-actions bot commented Dec 12, 2025 •
edited
Loading

Test Results - Preflight, Unit

23 001 tests  ±0   21 158 ✅ ±0   6m 19s ⏱️ -2s
     1 suites ±0    1 843 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit d317f0f. ± Comparison against base commit ee8518d.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Dec 12, 2025 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 3s ⏱️ +7s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit d317f0f. ± Comparison against base commit ee8518d.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Dec 12, 2025 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   2h 1m 5s ⏱️
3 751 tests 3 468 ✅ 283 💤 0 ❌
3 757 runs  3 468 ✅ 289 💤 0 ❌

Results for commit d317f0f.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Dec 12, 2025 •
edited
Loading

LocalStack Community integration with Pro

    2 files  ±    0      2 suites  ±0   1h 29m 14s ⏱️ - 27m 28s
3 727 tests  - 1 414  3 440 ✅  - 1 305  287 💤  - 109  0 ❌ ±0 
3 729 runs   - 1 414  3 440 ✅  - 1 305  289 💤  - 109  0 ❌ ±0 

Results for commit d317f0f. ± Comparison against base commit ee8518d.

This pull request removes 1414 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

♻️ This comment has been updated with latest results.

@anisaoshafi anisaoshafi force-pushed the lmi-validations branch 2 times, most recently from 316524e to 7ae8368 Compare December 12, 2025 23:30
@anisaoshafi anisaoshafi marked this pull request as ready for review December 13, 2025 13:09
joe4dev
joe4dev approved these changes Dec 15, 2025
View reviewed changes
localstack-core/localstack/services/lambda_/provider.py
region=region,
account_id=account_id,
# TODO: validations for PublishTo without Publish=True
publish_to=request.get("PublishTo"),
Copy link
Member

@joe4dev joe4dev Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super nit: could use publish_to

localstack-core/localstack/services/lambda_/provider.py

if "CapacityProviderConfig" in request:
capacity_provider_config = request["CapacityProviderConfig"]
self._validate_capacity_provider_config(capacity_provider_config, context)
Copy link
Member

@joe4dev joe4dev Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: nice catch 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joe4dev joe4dev joe4dev approved these changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

@dfangl dfangl Awaiting requested review from dfangl dfangl is a code owner

@gregfurman gregfurman Awaiting requested review from gregfurman gregfurman is a code owner

Assignees

No one assigned

Labels

aws:lambda AWS Lambda docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@anisaoshafi @joe4dev