Skip to content

Conversation

@jiaming2li
Copy link

Fixes #13488

Description:
The describe_instance_credit_specifications API was returning an invalid 'NextToken': 'string' (inherited from moto), which caused Terraform to fail/loop when handling pagination.

Changes:

  • Intercepted the describe_instance_credit_specifications call in Ec2Provider.
  • Explicitly removed the invalid NextToken field from the response.

Testing:

  • Verified locally with a reproduction script using boto3. Confirmed that NextToken is no longer present in the response.

@localstack-bot
Copy link
Contributor

localstack-bot commented Dec 12, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@jiaming2li
Copy link
Author

I have read the CLA Document and I hereby sign the CLA.

@jiaming2li
Copy link
Author

recheck

localstack-bot added a commit that referenced this pull request Dec 13, 2025
@jiaming2li
Copy link
Author

Ready for review! Could a maintainer please help add labels to trigger the checks? Thanks.

@viren-nadkarni
Copy link
Member

@jiaming2li Thanks for the PR. Unfortunately we're unable to accept this change because it addresses an upstream bug. Please submit this fix to Moto

@viren-nadkarni viren-nadkarni added the status: response required Waiting for a response from the reporter label Dec 15, 2025
@jiaming2li jiaming2li closed this Dec 15, 2025
@jiaming2li jiaming2li deleted the fix/ec2-credit-specs-nexttoken branch December 15, 2025 07:59
@jiaming2li jiaming2li restored the fix/ec2-credit-specs-nexttoken branch December 15, 2025 08:08
@jiaming2li jiaming2li reopened this Dec 15, 2025
@jiaming2li jiaming2li closed this Dec 15, 2025
@jiaming2li jiaming2li deleted the fix/ec2-credit-specs-nexttoken branch December 15, 2025 08:09
@jiaming2li jiaming2li restored the fix/ec2-credit-specs-nexttoken branch December 15, 2025 22:57
@jiaming2li jiaming2li reopened this Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: response required Waiting for a response from the reporter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: terraform fail after creating EC2 of burstable instance type (regression with DescribeInstanceCreditSpecifications API)

3 participants