Skip to content

Fix/ssm put parameter operation #13437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jasjaapdua wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix/ssm put parameter operation #13437

jasjaapdua wants to merge 2 commits into from

Conversation

@jasjaapdua
Copy link

@jasjaapdua jasjaapdua commented Nov 29, 2025 •
edited
Loading

Motivation

SSM put_parameter events currently always emit operation: "Create", even when overwriting an existing parameter. AWS emits operation: "Update" on overwrite, so downstream listeners see incorrect event detail in LocalStack.

Changes

  • Set the SSM event operation to "Update" when put_parameter returns a version > 1, otherwise "Create".
  • Added a unit test to assert Create→Update emission when overwriting.

Tests

  • python -m pytest tests/unit/test_ssm_put_parameter_events.py
  • make lint
  • make format

Related

@localstack-bot
Copy link
Contributor

localstack-bot commented Nov 29, 2025


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

localstack-bot
localstack-bot reviewed Nov 29, 2025
View reviewed changes
Copy link
Contributor

@localstack-bot localstack-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to LocalStack! Thanks for raising your first Pull Request and landing in your contributions. Our team will reach out with any reviews or feedbacks that we have shortly. We recommend joining our Slack Community and share your PR on the #community channel to share your contributions with us. Please make sure you are following our contributing guidelines and our Code of Conduct.

@jasjaapdua
Copy link
Author

jasjaapdua commented Nov 29, 2025

I have read the CLA Document and I hereby sign the CLA

@jasjaapdua
Copy link
Author

jasjaapdua commented Nov 29, 2025

The CI checks have failed because of missing labels and I don't have the permission to edit the labels now.

Could a maintainer please add the following labels?

  • docs:skip
  • notes:skip
  • semver:patch

This PR is a small bugfix that aligns the SSM PutParameter event behaviour with that of AWS. Thanks!

@viren-nadkarni viren-nadkarni added semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Dec 3, 2025
viren-nadkarni
viren-nadkarni requested changes Dec 3, 2025
View reviewed changes
Copy link
Member

@viren-nadkarni viren-nadkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising the PR!

tests/unit/test_ssm_put_parameter_events.py
Copy link
Member

@viren-nadkarni viren-nadkarni Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you write a AWS-validated integration test instead of this unit test? You can read more about them here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@localstack-bot localstack-bot localstack-bot left review comments

@viren-nadkarni viren-nadkarni viren-nadkarni requested changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: ssm parameter update should send "Update" event, but sends "Create" event

3 participants

@jasjaapdua @localstack-bot @viren-nadkarni