Skip to content

CFn: dont sort resources before deployment #13287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

CFn: dont sort resources before deployment #13287

wants to merge 3 commits into from

Conversation

@simonrw
Copy link
Contributor

@simonrw simonrw commented Oct 20, 2025

Motivation

TBD

Closes UNC-57

Changes

TBD

@simonrw simonrw added aws:eks Amazon Elastic Kubernetes Service semver: patch Non-breaking changes which can be included in patch releases aws:cloudformation:v2 Issues related to the V2 CloudFormation engine docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Oct 20, 2025
@github-actions
Copy link

github-actions bot commented Oct 20, 2025 •
edited
Loading

Test Results - Preflight, Unit

22 366 tests   20 616 ✅  16m 24s ⏱️
     1 suites   1 750 💤
     1 files         0 ❌

Results for commit 2ddd6f6.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 20, 2025 •
edited
Loading

LocalStack Community integration with Pro

  2 files  ±    0    2 suites  ±0   36m 0s ⏱️ - 1h 24m 16s
585 tests  - 4 293  471 ✅  - 4 052  114 💤  - 241  0 ❌ ±0 
587 runs   - 4 293  471 ✅  - 4 052  116 💤  - 241  0 ❌ ±0 

Results for commit 2ddd6f6. ± Comparison against base commit ee16f3c.

This pull request removes 4293 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 20, 2025 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests   5 ✅  3m 30s ⏱️
1 suites  2 💤
1 files    0 ❌

Results for commit 2ddd6f6.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 20, 2025 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

  5 files    5 suites   49m 26s ⏱️
609 tests 496 ✅ 113 💤 0 ❌
615 runs  496 ✅ 119 💤 0 ❌

Results for commit 2ddd6f6.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 20, 2025 •
edited
Loading

Test Results - Alternative Providers

584 tests   330 ✅  26m 32s ⏱️
  1 suites  254 💤
  1 files      0 ❌

Results for commit 2ddd6f6.

♻️ This comment has been updated with latest results.

@simonrw simonrw force-pushed the cfn/no-sorting-resources branch from 42bb7ff to 2ddd6f6 Compare October 21, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pinzon pinzon Awaiting requested review from pinzon pinzon will be requested when the pull request is marked ready for review pinzon is a code owner

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert will be requested when the pull request is marked ready for review dominikschubert is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

aws:cloudformation:v2 Issues related to the V2 CloudFormation engine aws:eks Amazon Elastic Kubernetes Service docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@simonrw