This repository was archived by the owner on Mar 23, 2026. It is now read-only.

DynamoDB: fix snapshot skip for MA/MR global table - #13270

Merged

bentsku merged 1 commit into

mainfrom

fix-ddb-snapshot

Oct 14, 2025

bentsku commented Oct 14, 2025 •

edited

Loading

Contributor

Motivation

Got a failing run here: https://github.com/localstack/localstack/runs/52736173569

Adding this snapshot skip to avoid the failure when running in MA/MR

Validated the fix locally with non default account and region

Changes

add Replicas snapshot skip


          fix snapshot skip

33c4713

bentsku self-assigned this

bentsku added aws:dynamodb semver: patch docs: skip notes: skip labels

bentsku marked this pull request as ready for review

October 14, 2025 19:43

bentsku requested review from dominikschubert, pinzon and simonrw as code owners

October 14, 2025 19:43

bentsku added the review: merge when ready label

github-actions Bot commented Oct 14, 2025

Test Results - Preflight, Unit

22 337 tests ±0 20 587 ✅ ±0 15m 31s ⏱️ -10s
1 suites ±0 1 750 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit 33c4713. ± Comparison against base commit 48d30e0.

gregfurman approved these changes

View reviewed changes

github-actions Bot commented Oct 14, 2025

LocalStack Community integration with Pro

2 files ± 0 2 suites ±0 36m 32s ⏱️ - 1h 22m 26s
585 tests - 4 232 471 ✅ - 4 009 114 💤 - 223 0 ❌ ±0
587 runs - 4 232 471 ✅ - 4 009 116 💤 - 223 0 ❌ ±0

Results for commit 33c4713. ± Comparison against base commit 48d30e0.

This pull request removes 4232 tests.

tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

github-actions Bot commented Oct 14, 2025

Test Results (amd64) - Acceptance

7 tests ±0 5 ✅ ±0 3m 29s ⏱️ +10s
1 suites ±0 2 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit 33c4713. ± Comparison against base commit 48d30e0.

github-actions Bot commented Oct 14, 2025

Test Results (amd64) - Integration, Bootstrap

5 files ± 0 5 suites ±0 49m 18s ⏱️ - 1h 50m 23s
609 tests - 4 582 496 ✅ - 4 198 113 💤 - 384 0 ❌ ±0
615 runs - 4 582 496 ✅ - 4 198 119 💤 - 384 0 ❌ ±0

Results for commit 33c4713. ± Comparison against base commit 48d30e0.

This pull request removes 4582 tests.

tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

github-actions Bot commented Oct 14, 2025

Test Results - Alternative Providers

584 tests - 784 330 ✅ - 382 26m 5s ⏱️ - 14m 12s
1 suites - 4 254 💤 - 402
1 files - 4 0 ❌ ± 0

Results for commit 33c4713. ± Comparison against base commit 48d30e0.

This pull request removes 784 tests.

tests.aws.services.cloudwatch.test_cloudwatch.TestCloudWatchMultiProtocol ‑ test_basic_operations_multiple_protocols[json]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudWatchMultiProtocol ‑ test_basic_operations_multiple_protocols[query]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudWatchMultiProtocol ‑ test_basic_operations_multiple_protocols[smithy-rpc-v2-cbor]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudWatchMultiProtocol ‑ test_exception_serializing_with_no_shape_in_spec[json]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudWatchMultiProtocol ‑ test_exception_serializing_with_no_shape_in_spec[query]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudWatchMultiProtocol ‑ test_exception_serializing_with_no_shape_in_spec[smithy-rpc-v2-cbor]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudWatchMultiProtocol ‑ test_multi_protocol_client_fixture[json]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudWatchMultiProtocol ‑ test_multi_protocol_client_fixture[query]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudWatchMultiProtocol ‑ test_multi_protocol_client_fixture[smithy-rpc-v2-cbor]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_alarm_lambda_target
…

bentsku merged commit 395f363 into main

65 checks passed

bentsku deleted the fix-ddb-snapshot branch

October 14, 2025 22:19

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

Labels

aws:dynamodb docs: skip notes: skip review: merge when ready semver: patch