Skip to content

CFn: validate conditions exist in Fn::If #13243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

CFn: validate conditions exist in Fn::If #13243

wants to merge 1 commit into from

Conversation

@simonrw
Copy link
Contributor

@simonrw simonrw commented Oct 8, 2025

Motivation

TBD

Changes

TBD

@simonrw simonrw added docs: skip Pull request does not require documentation changes aws:cloudformation AWS CloudFormation notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases labels Oct 8, 2025
@github-actions
Copy link

github-actions bot commented Oct 8, 2025

Test Results - Preflight, Unit

22 298 tests  ±0   20 555 ✅ ±0   15m 33s ⏱️ -17s
     1 suites ±0    1 743 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 39758c0. ± Comparison against base commit b2694a8.

@github-actions
Copy link

github-actions bot commented Oct 8, 2025

LocalStack Community integration with Pro

  2 files  ±    0    2 suites  ±0   35m 28s ⏱️ - 1h 27m 12s
582 tests  - 4 226  468 ✅  - 4 003  114 💤  - 223  0 ❌ ±0 
584 runs   - 4 226  468 ✅  - 4 003  116 💤  - 223  0 ❌ ±0 

Results for commit 39758c0. ± Comparison against base commit b2694a8.

This pull request removes 4227 and adds 1 tests. Note that renamed tests count towards both. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

tests.aws.services.cloudformation.test_change_set_conditions.TestChangeSetConditions ‑ test_missing_condition

@github-actions
Copy link

github-actions bot commented Oct 8, 2025

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 20s ⏱️ ±0s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 39758c0. ± Comparison against base commit b2694a8.

@github-actions
Copy link

github-actions bot commented Oct 8, 2025

Test Results (amd64) - Integration, Bootstrap

  5 files    5 suites   48m 32s ⏱️
606 tests 493 ✅ 113 💤 0 ❌
612 runs  493 ✅ 119 💤 0 ❌

Results for commit 39758c0.

@github-actions
Copy link

github-actions bot commented Oct 8, 2025

Test Results - Alternative Providers

581 tests   330 ✅  25m 34s ⏱️
  1 suites  251 💤
  1 files      0 ❌

Results for commit 39758c0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pinzon pinzon Awaiting requested review from pinzon pinzon will be requested when the pull request is marked ready for review pinzon is a code owner

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert will be requested when the pull request is marked ready for review dominikschubert is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

aws:cloudformation AWS CloudFormation docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@simonrw