Skip to content

CFn(chore): refactor post-deploy steps #13242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

CFn(chore): refactor post-deploy steps #13242

wants to merge 5 commits into from

Conversation

@simonrw
Copy link
Contributor

@simonrw simonrw commented Oct 8, 2025

Motivation

We have multiple places where after a change set execution, we need to propagate state back to the parent stack. These places are:

  • execute_change_set
  • create_stack
  • update_stack
  • delete_stack (sort of)

These should probably have the same behaviour to make sure we don't forget to propagate state somewhere

Changes

  • Extract helper method to propagate change set to stack
  • Ensure child stack failures work
  • Refactor deletion method

@simonrw simonrw added semver: patch Non-breaking changes which can be included in patch releases aws:cloudformation:v2 Issues related to the V2 CloudFormation engine docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Oct 8, 2025
@github-actions
Copy link

github-actions bot commented Oct 8, 2025 •
edited
Loading

Test Results - Preflight, Unit

22 298 tests  ±0   20 555 ✅ ±0   15m 55s ⏱️ +5s
     1 suites ±0    1 743 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 3449b53. ± Comparison against base commit b2694a8.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 8, 2025 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 19s ⏱️ -1s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 3449b53. ± Comparison against base commit b2694a8.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 8, 2025 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

  5 files    5 suites   48m 9s ⏱️
605 tests 490 ✅ 113 💤 2 ❌
611 runs  490 ✅ 119 💤 2 ❌

For more details on these failures, see this check.

Results for commit 3449b53.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 8, 2025 •
edited
Loading

Test Results - Alternative Providers

580 tests   330 ✅  25m 19s ⏱️
  1 suites  250 💤
  1 files      0 ❌

Results for commit 3449b53.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 8, 2025 •
edited
Loading

LocalStack Community integration with Pro

  2 files  ±    0    2 suites  ±0   35m 18s ⏱️ - 1h 27m 22s
581 tests  - 4 227  465 ✅  - 4 006  114 💤  - 223  2 ❌ +2 
583 runs   - 4 227  465 ✅  - 4 006  116 💤  - 223  2 ❌ +2 

For more details on these failures, see this check.

Results for commit 3449b53. ± Comparison against base commit b2694a8.

This pull request removes 4227 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pinzon pinzon Awaiting requested review from pinzon pinzon will be requested when the pull request is marked ready for review pinzon is a code owner

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert will be requested when the pull request is marked ready for review dominikschubert is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

aws:cloudformation:v2 Issues related to the V2 CloudFormation engine docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@simonrw