This repository was archived by the owner on Mar 23, 2026. It is now read-only.
Conversation
k-a-il
changed the title
k-a-il
added
the
semver: patch
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 2h 21m 2s ⏱️ Results for commit 8b3c93d. ♻️ This comment has been updated with latest results. |
k-a-il
requested review from
a team,
ArthurAkh,
bentsku,
sannya-singal and
silv-io
and removed request for
ArthurAkh,
bentsku,
sannya-singal and
silv-io
August 19, 2025 12:12
k-a-il
marked this pull request as ready for review
August 19, 2025 13:00
bentsku
reviewed
Aug 19, 2025
Contributor
There was a problem hiding this comment.
edit: oops, sent without the full message 😅
This is great, thanks for adding this! It will be easier to iterate over it collectively 🚀
I think it would be good to add a CODEOWNERS entry for this module back to our squad, so it'd be easier for review 👍
I only have a comment around the factory of the class, in order to extend it from Pro and allow us to transparently modify behavior of the callers of the class
Collaborator
Author
|
Closing this PR because it is part of #13027 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Create initial structure for AWS and CloudFormation catalogs.
Changes
AwsServicesCatalogandCloudFormationCatalog