Skip to content

Bugfix/eventbridge/step functions target id input key#12099

Draft
maxhoheiser wants to merge 8 commits intomainfrom
bugfix/eventbridge/step-functions-target-id-input-key
Draft

Bugfix/eventbridge/step functions target id input key#12099
maxhoheiser wants to merge 8 commits intomainfrom
bugfix/eventbridge/step-functions-target-id-input-key

Conversation

@maxhoheiser
Copy link
Member

Motivation

Some target senders rely on specific fields from the event e.g. the event id, if an input transformer or input path is applied to the event, these keys could be removed, and the sending of the event will fail.

This PR fixes the problem addresses in this github bug report: #11970

Changes

Optionally supply the input_event (no input transformer or input path applied for transformation) to the respective send_event method of Kinesis sender and Step Functions sender.

Testing

Add test send event to target kinesis with input transformer enabled
Add test send event to target step functions with input transformer enabled

@maxhoheiser maxhoheiser added the aws:events Amazon EventBridge label Jan 3, 2025
@maxhoheiser maxhoheiser self-assigned this Jan 3, 2025
@maxhoheiser maxhoheiser added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label Jan 3, 2025
@maxhoheiser maxhoheiser force-pushed the bugfix/eventbridge/step-functions-target-id-input-key branch 2 times, most recently from edaecc3 to e5e5bc1 Compare January 9, 2025 14:05
@silv-io silv-io added this to the Playground milestone Jan 27, 2025
@kamilturek
Copy link

Hey @maxhoheiser @silv-io, is there any chance for moving it forward?

@maxhoheiser maxhoheiser force-pushed the bugfix/eventbridge/step-functions-target-id-input-key branch from e5e5bc1 to ab6958f Compare July 23, 2025 08:46
@maxhoheiser maxhoheiser marked this pull request as ready for review July 23, 2025 08:49
@maxhoheiser maxhoheiser requested a review from bentsku as a code owner July 23, 2025 08:49
@github-actions
Copy link

github-actions bot commented Jul 23, 2025

Test Results - Preflight, Unit

21 983 tests  ±0   20 249 ✅ ±0   6m 21s ⏱️ -4s
     1 suites ±0    1 734 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 97a9d6f. ± Comparison against base commit 6004587.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jul 23, 2025

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 5s ⏱️ -3s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 97a9d6f. ± Comparison against base commit 6004587.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jul 23, 2025

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   2h 21m 39s ⏱️
2 653 tests 2 464 ✅ 105 💤 84 ❌
2 659 runs  2 464 ✅ 111 💤 84 ❌

For more details on these failures, see this check.

Results for commit 97a9d6f.

♻️ This comment has been updated with latest results.

@maxhoheiser maxhoheiser marked this pull request as draft July 23, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aws:events Amazon EventBridge semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants