Remove legacy ESM CI job #11779
Merged
Remove legacy ESM CI job #11779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe4dev
added
the
semver: patch
joe4dev
requested review from
alexrashed,
dfangl and
dominikschubert
as code owners
alexrashed
approved these changes
Nov 5, 2024
Member
alexrashed
left a comment
alexrashed
left a comment
There was a problem hiding this comment.
Nice and clean preparation! 💯 🧹
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We can remove the CI step earlier to minimize the changes in the PR removing the legacy ESM feature (#11733) and mitigate merge conflicts.
Learned from the S3 example by @bentsku #11743
Changes