Skip to content

Conversation

@joe4dev
Copy link
Member

@joe4dev joe4dev commented Nov 4, 2024

Motivation

We can remove the CI step earlier to minimize the changes in the PR removing the legacy StepFunctions provider (#11734) and mitigate merge conflicts.
Learned from the S3 example by @bentsku #11743

Changes

  • remove the legacy StepFunction CI job

@joe4dev joe4dev added the semver: patch Non-breaking changes which can be included in patch releases label Nov 4, 2024
@joe4dev joe4dev added this to the 4.0 milestone Nov 4, 2024
@joe4dev joe4dev self-assigned this Nov 4, 2024
@github-actions
Copy link

github-actions bot commented Nov 4, 2024

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 42m 6s ⏱️ +12s
3 532 tests ±0  3 118 ✅ ±0  414 💤 ±0  0 ❌ ±0 
3 534 runs  ±0  3 118 ✅ ±0  416 💤 ±0  0 ❌ ±0 

Results for commit 61c468b. ± Comparison against base commit 1db9b8f.

@joe4dev joe4dev marked this pull request as ready for review November 4, 2024 22:18
Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean removal! 💯 🧹

@joe4dev joe4dev merged commit efc629f into master Nov 5, 2024
@joe4dev joe4dev deleted the remove-legacy-stepfunctions-ci branch November 5, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants