Remove legacy Lambda ESM v1 feature#11733
Merged
joe4dev merged 1 commit intorelease/v4from Nov 7, 2024
Merged
Conversation
Contributor
|
Currently, only minor and patch changes are allowed on master. Your PR labels (semver: major) indicate that it cannot be merged into the master at this time. |
S3 Image Test Results (AMD64 / ARM64) 2 files 2 suites 3m 34s ⏱️ Results for commit ede91bb. ♻️ This comment has been updated with latest results. |
2fe8fd5 to
7974616
Compare
This was referenced Nov 4, 2024
7974616 to
9301dba
Compare
gregfurman
approved these changes
Nov 5, 2024
Contributor
gregfurman
left a comment
There was a problem hiding this comment.
LGTM 👍 Mostly nits and questions. Anything suggested can easily be done in a follow-up or ignored.
localstack-core/localstack/services/lambda_/event_source_mapping/pollers/kinesis_poller.py
Show resolved
Hide resolved
localstack-core/localstack/services/lambda_/event_source_mapping/pollers/sqs_poller.py
Show resolved
Hide resolved
localstack-core/localstack/services/lambda_/event_source_mapping/pollers/sqs_poller.py
Show resolved
Hide resolved
tests/aws/services/lambda_/event_source_mapping/test_lambda_integration_dynamodbstreams.py
Show resolved
Hide resolved
9301dba to
ede91bb
Compare
alexrashed
pushed a commit
that referenced
this pull request
Nov 8, 2024
bentsku
added a commit
that referenced
this pull request
Nov 8, 2024
joe4dev
added a commit
that referenced
this pull request
Nov 12, 2024
joe4dev
pushed a commit
that referenced
this pull request
Nov 12, 2024
dfangl
pushed a commit
that referenced
this pull request
Nov 14, 2024
dominikschubert
pushed a commit
that referenced
this pull request
Nov 14, 2024
dominikschubert
pushed a commit
that referenced
this pull request
Nov 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on CI step removal #11779
Motivation
The new Lambda Event Source Mapping (ESM) implementation v2 has been the default implementation since 3.8.0 and we announced the removal of ESM v1 with the next major release in the release notes.
Changes
LAMBDA_EVENT_SOURCE_MAPPINGand all dependenciesLAMBDA_EVENT_SOURCE_MAPPINGto deprecationsLAMBDA_EVENT_SOURCE_MAPPINGlocalstack-core/localstack/services/lambda_/event_source_listenersfrom localstack.services.lambda_.event_source_listeners.utils import message_attributes_to_lowerfrom localstack.services.lambda_.event_source_listeners.utils import ( has_data_filter_criteria_parsed,)LAMBDA_SQS_EVENT_SOURCE_MAPPING_INTERVAL_SEC(we should have deprecated it earlier, but it's undocumented)Testing
Mostly regression test suite.
Could check deprecation warnings manually.
TODO
What's left to do:
Discussion
tests/aws/services/events/test_events_patterns.py(summary of different implementations in Add event matching test suite #10599)