Init hooks: Remove default AWS credentials #11705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viren-nadkarni
added
the
semver: major
viren-nadkarni
force-pushed
the
init-hook-credentials
branch
from
787c113 to
18c74da
Compare
viren-nadkarni
requested review from
alexrashed,
bentsku,
dominikschubert,
gregfurman,
joe4dev,
pinzon and
simonrw
as code owners
viren-nadkarni
removed request for
bentsku,
dfangl,
dominikschubert,
gregfurman,
joe4dev,
pinzon and
simonrw
viren-nadkarni
requested review from
dfangl and
dominikschubert
and removed request for
thrau
dfangl
approved these changes
Nov 11, 2024
Member
dfangl
left a comment
dfangl
left a comment
There was a problem hiding this comment.
LGTM, nice to get rid of this!
viren-nadkarni
force-pushed
the
init-hook-credentials
branch
from
18c74da to
034383f
Compare
joe4dev
pushed a commit
that referenced
this pull request
Nov 12, 2024
dfangl
pushed a commit
that referenced
this pull request
Nov 14, 2024
dominikschubert
pushed a commit
that referenced
this pull request
Nov 14, 2024
dominikschubert
pushed a commit
that referenced
this pull request
Nov 14, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
This is a breaking change designated for LocalStack v4.0.0
Background
The old implementation of multi-accounts in LocalStack used environment variables that determined the account/region of the sandbox. This impacted various other features, most notably the init hooks where we used to inherit the same environment variables when running the startup script. The startup scripts could be written without the need for explicit AWS credentials.
Since then, LocalStack moved to a multi-accounts implementation based on the request context. It no longer requires a global env var setting of account/region. But to maintain backward compatibility with existing init hook startup scripts, we started setting default account/region values in its environment.
Changes
With LocalStack v4, the default AWS credentials will no longer be set in the init hook execution environment.
Startup scripts will now be required to set explicit credentials.
Related
Closes: