Feature catalog generate output, add generic ApiLimitation#11606
Merged
steffyP merged 5 commits intoplayground_feature_catalogfrom Oct 1, 2024
Merged
Feature catalog generate output, add generic ApiLimitation#11606steffyP merged 5 commits intoplayground_feature_catalogfrom
steffyP merged 5 commits intoplayground_feature_catalogfrom
Conversation
…d kms-feature catalog files
steffyP
commented
Oct 1, 2024
Comment on lines
+374
to
+375
| @kms_api.CreateKey | ||
| @ApiLimitation(limitation="Status 'Updating' is not supported.") |
Member
Author
There was a problem hiding this comment.
testing both approaches here: adding additional Limitations for an API operation using either a specific decorator kms_api.CreateKey or a generic one ApiLimitation.
- the second option
ApiLimitationcan be reused for every operation, and we can provide the actual limitations as input (currently string, but we could change this to a list as well).- if there are a lot of limitations we could use constants that are defined in a separate file, to not pollute the code too much
- tested this approach in the
playground.pyscript, e.g. it will be added asapi_limitation:
"Provisioning": { "docs": { "general_docs": "Manage the creation and modification of the keys.", "implementation_status": "ImplementationStatus.FULLY_IMPLEMENTED", "support_type": "SupportStatus.SUPPORTED", "aws_docs_link": "https://docs.aws.amazon.com/kms/latest/developerguide/create-keys.html", "api_operations": [ "CreateKey" ] }, "operations": [ "localstack.services.kms.provider.KmsProvider.create_key", "localstack.services.kms.provider.KmsProvider.update_key_description" ], "api_limitations": { "localstack.services.kms.provider.KmsProvider.create_key": "Status 'Updating' is not supported." } },
steffyP
commented
Oct 1, 2024
| "PublicKey": crypto_key.public_key, | ||
| } | ||
|
|
||
| @handler("GenerateDataKeyPair") |
Member
Author
There was a problem hiding this comment.
i had to remove the empty handlers, as these somehow interfered with the tests in asf_utils.py - didn't investigate further, I am sure we could solve this and keeping the handler. On the other hand the handler doesn't do anything here :)
steffyP
commented
Oct 1, 2024
Member
Author
There was a problem hiding this comment.
moved the script and adapted the paths. Originally added by @sannya-singal in #11593
sannya-singal
approved these changes
Oct 1, 2024
Contributor
|
Closing #11593 as the current branch pulls the related changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR is building on #11593, which in turn already builds on #11592.
The PR is targeting the playground_feature_catalog branch (#11592).
Changes
ApiLimitationthan could be used in a generic way for specific api operations