Skip to content

make next-gen APIGW provider default #11035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bentsku merged 2 commits into from
Nov 3, 2024
Merged

make next-gen APIGW provider default #11035

bentsku merged 2 commits into from
Nov 3, 2024

Conversation

@bentsku
Copy link
Contributor

@bentsku bentsku commented Jun 17, 2024 •
edited
Loading

Motivation

This PR makes the APIGW NextProvider to be the default used.

This PR also compiles all PRs done related to this work.

Changes

  • make the NextGen provider default

NG Provider

Follow-up?

TODO

What's left to do:

  • move the code from the next_gen module back into default? TBD

Once this PR is merged:

  • remove the NextGen CI step

@bentsku bentsku added aws:apigateway Amazon API Gateway semver: patch Non-breaking changes which can be included in patch releases semver: major Breaking changes which can be included in a major release only labels Jun 17, 2024
@bentsku bentsku self-assigned this Jun 17, 2024
@bentsku bentsku added semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases and removed semver: major Breaking changes which can be included in a major release only semver: patch Non-breaking changes which can be included in patch releases labels Jun 17, 2024
@github-actions
Copy link

github-actions bot commented Jun 17, 2024 •
edited
Loading

S3 Image Test Results (AMD64 / ARM64)

  2 files    2 suites   3m 43s ⏱️
421 tests 369 ✅  52 💤 0 ❌
842 runs  738 ✅ 104 💤 0 ❌

Results for commit 87154d4.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jun 17, 2024 •
edited
Loading

LocalStack Community integration with Pro

    2 files      2 suites   1h 43m 5s ⏱️
3 518 tests 3 109 ✅ 409 💤 0 ❌
3 520 runs  3 109 ✅ 411 💤 0 ❌

Results for commit 87154d4.

♻️ This comment has been updated with latest results.

@bentsku bentsku added this to the Playground milestone Jun 19, 2024
@bentsku bentsku changed the title force enable next-gen APIW provider force enable next-gen APIGW provider Jul 18, 2024
@cloutierMat cloutierMat force-pushed the next-gen-apigw branch 2 times, most recently from a8c26a1 to 50f1fd6 Compare September 20, 2024 19:47
@bentsku bentsku force-pushed the next-gen-apigw branch 3 times, most recently from d2086fb to 65e70b5 Compare September 30, 2024 22:39
@bentsku bentsku mentioned this pull request Sep 30, 2024
Merged
1 task
@bentsku bentsku force-pushed the next-gen-apigw branch 3 times, most recently from 3178286 to 9282c21 Compare October 3, 2024 00:19
@localstack-bot
Copy link
Contributor

localstack-bot commented Oct 3, 2024

Currently, only patch changes are allowed on master. Your PR labels (aws:apigateway, semver: minor) indicate that it cannot be merged into the master at this time.

@bentsku bentsku changed the title force enable next-gen APIGW provider make next-gen APIGW provider default Oct 25, 2024
@bentsku bentsku mentioned this pull request Oct 28, 2024
Merged
@bentsku bentsku removed this from the Playground milestone Oct 28, 2024
@bentsku bentsku added this to the 4.0 milestone Oct 28, 2024
@bentsku bentsku changed the base branch from master to release/v4 October 31, 2024 00:13
@bentsku bentsku marked this pull request as ready for review October 31, 2024 12:04
@bentsku bentsku requested a review from thrau as a code owner October 31, 2024 12:04
alexrashed
alexrashed approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Great to see the API GW provider becoming the default! :shipit: 💯

@bentsku bentsku merged commit ee3b510 into release/v4 Nov 3, 2024
@bentsku bentsku deleted the next-gen-apigw branch November 3, 2024 22:16
joe4dev pushed a commit that referenced this pull request Nov 5, 2024
@bentsku @joe4dev
make next-gen APIGW provider default (#11035)
11c302d
dfangl pushed a commit that referenced this pull request Nov 6, 2024
@bentsku @dfangl
make next-gen APIGW provider default (#11035)
0de916a
@alexrashed alexrashed mentioned this pull request Nov 7, 2024
Merged
9 tasks
alexrashed pushed a commit that referenced this pull request Nov 8, 2024
@bentsku @alexrashed
make next-gen APIGW provider default (#11035)
f5b7c8a
joe4dev pushed a commit that referenced this pull request Nov 12, 2024
@bentsku @joe4dev
make next-gen APIGW provider default (#11035)
40473c0
dfangl pushed a commit that referenced this pull request Nov 14, 2024
@bentsku @dfangl
make next-gen APIGW provider default (#11035)
35e86af
dominikschubert pushed a commit that referenced this pull request Nov 14, 2024
@bentsku @dominikschubert
make next-gen APIGW provider default (#11035)
f6bf9c1
dominikschubert pushed a commit that referenced this pull request Nov 14, 2024
@bentsku @dominikschubert
make next-gen APIGW provider default (#11035)
c446a3e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexrashed alexrashed alexrashed approved these changes

@cloutierMat cloutierMat Awaiting requested review from cloutierMat

@thrau thrau Awaiting requested review from thrau

Assignees

@bentsku bentsku

@cloutierMat cloutierMat

Labels

aws:apigateway Amazon API Gateway semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases

Projects

None yet

Milestone

4.0

Development

Successfully merging this pull request may close these issues.

4 participants

@bentsku @localstack-bot @alexrashed @cloutierMat