Conversation
51d92c2 to
9424427
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
I updated our
copilot-localrepo to the latest upstream commit, and it did not work against LocalStack any more. I am not 100% sure the current commit works either.The initial failure reason was our StackSet support in CloudFormation.
Changes
get_template_bodyto allow use of the previous stack (UsePreviousStack)StackSetentity mostly allowing access to the template body for use byStackInstancesStackInstanceparameter overrides withStackSetparameter definitionsconvert_in_place_at_jsonpathfor deep nested structure in place type conversiontest_create_stack_set_with_stack_instancestest to support parameter overridesTesting
I have been testing with my fork of copilot-local which has a few changes to the LocalStack fork of copilot:
localstackbranch has been rebased onto the latest tagged release (v1.33.3 at the time of writing)As of 2024-06-07 I had not yet completed the work required to fix copilot-local. I think I was close, but not there yet.