fix cfn templates deployed in invalid AZs#10586
Merged
sannya-singal merged 1 commit intomasterfrom Apr 2, 2024
Merged
Conversation
sannya-singal
added
the
semver: patch
sannya-singal
requested review from
Morijarti,
dominikschubert,
pinzon and
simonrw
as code owners
Morijarti
approved these changes
Apr 2, 2024
Contributor
Morijarti
left a comment
Morijarti
left a comment
There was a problem hiding this comment.
LGTM :)
Thank you for making the changes and making CFn's handling of AZs more robust
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
While working on greenifying cross accounts pipeline #10563, we discovered the issue with creating cfn templates in invalid availability zones.
Changes
This PR:
"a", "b", "c", "d", "e", "f", we callconnect_to().ec2.describe_availability_zones(...)ap-northeast-1and validate against AWS #10563 for deploying the templates specifically inus-east-1.