make twisted default HTTP server in S3 image #10491
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Following the introduction of Twisted as the HTTP server of LocalStack in an opt-in manner with #9834, we could make it default in the S3 only image, as we know it is way more performant.
Changes
GATEWAY_SERVER=twistedin the S3-only Docker image to make it defaultBenchmarks
Concurrency of 1, small object size of 1000.
-> Around 8x performance
Concurrency of 25, small object size of 1000
-> Around 3x performance, but with no massive variations and no errors or blocking operations
Concurrency of 25, medium object size of 100000
-> Around 3x performance too, but with no massive variations or blocking operations