Skip to content

Conversation

@bentsku
Copy link
Contributor

@bentsku bentsku commented Mar 19, 2024

Motivation

Following the introduction of Twisted as the HTTP server of LocalStack in an opt-in manner with #9834, we could make it default in the S3 only image, as we know it is way more performant.

Changes

  • set GATEWAY_SERVER=twisted in the S3-only Docker image to make it default

Benchmarks

Concurrency of 1, small object size of 1000.

Twisted:   Average: 1.54 MiB/s, 1620.03 obj/s
Hypercorn: Average: 0.21 MiB/s, 219.67 obj/s

-> Around 8x performance

Concurrency of 25, small object size of 1000

Twisted:   Average: 1.78 MiB/s, 1864.04 obj/s
Hypercorn: Average: 0.55 MiB/s, 572.70 obj/s (encountered 9 time out)

Twisted:   Slowest: 1624.7KiB/s, 1663.71 obj/s
Hypercorn: Slowest: 2.7KiB/s, 2.83 obj/s

-> Around 3x performance, but with no massive variations and no errors or blocking operations

Concurrency of 25, medium object size of 100000

Twisted:   Average: 160.13 MiB/s, 1679.13 obj/s
Hypercorn: Average: 52.99 MiB/s, 555.62 obj/s (encountered 8 time out)

Twisted:   Slowest: 153.2MiB/s, 1606.23 obj/s
Hypercorn: Slowest: 301.7KiB/s, 3.09 obj/s

-> Around 3x performance too, but with no massive variations or blocking operations

@bentsku bentsku added aws:s3 Amazon Simple Storage Service semver: patch Non-breaking changes which can be included in patch releases labels Mar 19, 2024
@bentsku bentsku requested a review from thrau March 19, 2024 14:31
@bentsku bentsku self-assigned this Mar 19, 2024
@github-actions
Copy link

S3 Image Test Results (AMD64 / ARM64)

  2 files    2 suites   2m 59s ⏱️
393 tests 342 ✅  51 💤 0 ❌
786 runs  684 ✅ 102 💤 0 ❌

Results for commit ea8464b.

Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea setting it for the image specifically! This reduces the "blast radius" initially and can give us some good feedback as well.

@bentsku bentsku merged commit 582e3c1 into master Mar 19, 2024
@bentsku bentsku deleted the s3-image-twisted branch March 19, 2024 16:12
@bentsku bentsku added this to the 3.3 milestone Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aws:s3 Amazon Simple Storage Service semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants