Skip to content

Conversation

@silv-io
Copy link
Member

@silv-io silv-io commented Mar 13, 2024

Motivation

The key for the non-python package data is set to localstack_ext which is wrong and leaves out those files in the distribution.

Changes

Change the key to the correct localstack so that those files are included

@silv-io silv-io requested a review from alexrashed March 13, 2024 09:11
@alexrashed alexrashed added the semver: patch Non-breaking changes which can be included in patch releases label Mar 13, 2024
@alexrashed alexrashed added this to the 3.3 milestone Mar 13, 2024
Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for jumping on this! 🚀 🧹
FYI: This doesn't have any impact on localstack/localstack but only on the distribution package (localstack-core) used by downstream projects.

@alexrashed
Copy link
Member

FYI: I tested the fix locally on my machine (make clean install-dev clean-dist dist) and the distribution now contains the CloudFormation resource provider JSON files missing in the current distribution.
I will move forward and merge this PR (especially because the tests do not cover this properly).

@alexrashed alexrashed merged commit 411a397 into master Mar 13, 2024
@alexrashed alexrashed deleted the fix-package-data branch March 13, 2024 09:43
@coveralls
Copy link

Coverage Status

Changes unknown
when pulling f9a5032 on fix-package-data
into ** on master**.

@thrau thrau mentioned this pull request Mar 13, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants