Skip to content

Conversation

@alexrashed
Copy link
Member

@alexrashed alexrashed commented Feb 7, 2024

Motivation

#10127 introduced dependency pinning.
This is a good opportunity to revisit current pins in the setup.cfg and try to upgrade as much as possible, as well as to remove some safety pins which have just defined to avoid breaking changes in the future (which is not necessary, because this only happens in a dedicated PR now).

Changes

TODO

  • Check failures in the test pipeline (also make sure to execute downstream pipelines).
    • There are 4 remaining test failures in the pipeline testing the pro integration. These are related to the upgrade of the test naming to pytest 8: 6105fed
    • This means that this PR will cause integration issues which will be resolved by upgrading to pytest 8 there as well.
    • Another option would be to duplicate the snapshot data for both naming styles, but I don't think this is necessary.
  • Maybe circle back on pins which are still necessary (and inform service owners + add comments).
    • After several iterations, we identified the minimum needed pins (as listed above).

@alexrashed alexrashed added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label Feb 7, 2024
@alexrashed alexrashed added this to the 3.2 milestone Feb 7, 2024
@alexrashed alexrashed requested a review from silv-io February 7, 2024 16:10
@github-actions
Copy link

github-actions bot commented Feb 7, 2024

S3 Image Test Results (AMD64 / ARM64)

  2 files    2 suites   3m 23s ⏱️
386 tests 336 ✅  50 💤 0 ❌
772 runs  672 ✅ 100 💤 0 ❌

Results for commit eb99701.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 7, 2024

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 22m 10s ⏱️ - 3m 6s
2 626 tests ±0  2 373 ✅  - 3  249 💤 ±0  4 ❌ +3 
2 628 runs  ±0  2 373 ✅  - 3  251 💤 ±0  4 ❌ +3 

For more details on these failures, see this check.

Results for commit eb99701. ± Comparison against base commit 361abbf.

♻️ This comment has been updated with latest results.

@coveralls
Copy link

coveralls commented Feb 8, 2024

Coverage Status

coverage: 83.87% (+0.006%) from 83.864%
when pulling eb99701 on unpin-deps-setupcfg
into 361abbf on master.

@alexrashed alexrashed requested a review from giograno February 8, 2024 12:27
@alexrashed alexrashed marked this pull request as ready for review February 8, 2024 12:28
@alexrashed alexrashed changed the title remove pins in setup.cfg remove pins in setup.cfg, add .python-version Feb 8, 2024
@alexrashed alexrashed requested a review from silv-io February 8, 2024 12:37
Copy link
Member

@silv-io silv-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a small thought and question

@alexrashed alexrashed merged commit bba2ac2 into master Feb 9, 2024
@alexrashed alexrashed deleted the unpin-deps-setupcfg branch February 9, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants