Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
87 commits
Select commit Hold shift + click to select a range
480e984
gh-249 Remove MDB_UNSIGNEDKEY, let CursorIterable call mdb_cmp
at055612 Mar 6, 2025
46f8d08
gh-249 Remove non-J8 features, use indent size 2
at055612 Mar 6, 2025
f92012e
gh-249 Fix indents
at055612 Mar 6, 2025
e1756d6
gh-249 Tidy code and refactor RangeComparator impls
at055612 Mar 6, 2025
9509f6b
gh-249 Remove commented code
at055612 Mar 6, 2025
67e2df1
gh-249 Add CursorIterableIntegerKeyTest
at055612 Mar 7, 2025
620a89f
gh-249 Remove MaskedFlag.isPropagatedToLmdb, add DbiBuilder WIP
at055612 Jun 5, 2025
75d87d0
Merge branch 'master' into mdb_cmp
at055612 Oct 26, 2025
47b4c4f
Merge branch 'master' into mdb_cmp
at055612 Oct 26, 2025
bfbf223
Add FlagSet, DbiFlagSet, PutFlagSet
at055612 Oct 27, 2025
0f66aaf
Rename FlagSet to AbstractFlagSet
at055612 Oct 27, 2025
aa000a1
Add remaining FlagSet impls
at055612 Oct 27, 2025
667dab3
Fix Javadoc
at055612 Oct 27, 2025
b46c916
Add more cursor tests to protect against future regression
stroomdev66 Oct 28, 2025
0234d32
Replace get(Uns|S)ignedComparator with getComparator(DbiFlagSet)
at055612 Oct 28, 2025
ef0c852
Add missing txn commit in DbiBuilder
at055612 Oct 28, 2025
1b3f94d
Change CursorIterableTest to use Parameterized
at055612 Oct 28, 2025
c0bbe73
Deprecate methods using varargs flags
at055612 Oct 28, 2025
4fd89ff
Add int key compare method to (Direct|Byte)BufferProxy
at055612 Oct 29, 2025
916b441
Merge branch 'master' of github.com:lmdbjava/lmdbjava into more-curso…
stroomdev66 Oct 29, 2025
58dcc6e
Tidy code
at055612 Oct 29, 2025
26665ba
Fix byte order issues with compareAsIntegerKeys
at055612 Oct 29, 2025
dc0b96b
#267 Fix to establish start key when iterating backwards from a start…
stroomdev66 Oct 29, 2025
9db91a5
Merge branch 'master' of github.com:lmdbjava/lmdbjava into gh-267
stroomdev66 Oct 30, 2025
c427801
Add/refactor tests
at055612 Nov 4, 2025
f606e7e
Merge branch 'master' into mdb_cmp
at055612 Nov 4, 2025
e2be6bf
Add integer key comparator tests
at055612 Nov 5, 2025
7374fde
#267 Fix to establish start key when iterating backwards from a start…
stroomdev66 Nov 5, 2025
79c0df6
Merge branch 'master' of github.com:lmdbjava/lmdbjava into gh-267
stroomdev66 Nov 5, 2025
787d6d3
#267 Fix to establish start key when iterating backwards from a start…
stroomdev66 Nov 5, 2025
c289763
#267 Fix to establish start key when iterating backwards from a start…
stroomdev66 Nov 5, 2025
1acd971
Add ComparatorFactory
at055612 Nov 5, 2025
69eb5b7
#269 Initial iterator performance enhancements and testing.
stroomdev66 Nov 5, 2025
915edce
#269 Initial iterator performance enhancements and testing.
stroomdev66 Nov 5, 2025
dea7975
Merge branch 'master' into mdb_cmp
at055612 Nov 5, 2025
5a62965
Merged new comparator code
stroomdev66 Nov 5, 2025
484a772
Merged new comparator code
stroomdev66 Nov 5, 2025
ad75cb2
Fix CodeQL issues, add setMapSizeXx methods
at055612 Nov 5, 2025
77a3494
Fix failing test
at055612 Nov 5, 2025
1d46e0b
Refactor deprecated method calls
at055612 Nov 6, 2025
577062f
Fix compile issue
at055612 Nov 6, 2025
12a9679
Improve FlagSet tests
at055612 Nov 6, 2025
7a6910b
Add licence header
at055612 Nov 6, 2025
167cdad
Rename buildDbi to createDbi to be consistent with Env.create()
at055612 Nov 6, 2025
d47694e
Remove ByteUnits dep, add ByteUnit enum, add setMapSize() overload
at055612 Nov 6, 2025
fb08779
Fix compile errors
at055612 Nov 6, 2025
a82d7f2
Add more test coverage
at055612 Nov 6, 2025
534b76b
Fix codeQL issue
at055612 Nov 6, 2025
e9f9ac4
Add test coverage on FlagSet
at055612 Nov 6, 2025
b0112bb
Add tests
at055612 Nov 6, 2025
c25a7d2
Run format plugin
at055612 Nov 7, 2025
cf3a11e
Remove class separators
at055612 Nov 7, 2025
0c97cf4
Run format plugin
at055612 Nov 7, 2025
72d4e3f
Remove binaries accidentally added, fix test
at055612 Nov 7, 2025
18013fb
Merged new comparator code
stroomdev66 Nov 7, 2025
6b40d0b
Merge branch 'gh-267_plus_new_comparators' into gh-249-remove-unsigne…
at055612 Nov 7, 2025
48aa0fd
Fix javadoc warnings and class visibility, fix licence warnings
at055612 Nov 7, 2025
72b5234
Auto-format
at055612 Nov 7, 2025
dd95dea
Add error handling for parse(Int|Long)
at055612 Nov 7, 2025
b53378a
Remove unused code
at055612 Nov 7, 2025
deb1f1b
Remove unused code
at055612 Nov 7, 2025
2bfe07c
Remove unused hashCode methods
at055612 Nov 7, 2025
a84ceaa
Change CursorIterableRangeTest to do default+native modes
at055612 Nov 9, 2025
a5e4cf2
Remove separator comments
at055612 Nov 9, 2025
f8e6e07
Add more tests to CursorIterableRangeTest
at055612 Nov 9, 2025
6982aca
Remove unused test, auto format
at055612 Nov 9, 2025
6740e2b
Add tests to stop CodeQL warnings
at055612 Nov 12, 2025
0103f13
Auto format
at055612 Nov 12, 2025
4249566
Fix typo in javadoc
at055612 Nov 12, 2025
35b0a9d
Tidy code
at055612 Nov 12, 2025
9a35718
Add in test classes for deprecated methods
at055612 Nov 14, 2025
8c19bf4
Add test coverage
at055612 Nov 14, 2025
496e5ea
Add test coverage
at055612 Nov 14, 2025
7bd3332
Auto format
at055612 Nov 14, 2025
06523f9
Add more tests
at055612 Nov 14, 2025
fe41338
Add test coverage
at055612 Nov 14, 2025
38eac0d
Add ByteBufProxyTest, refactor some test classes
at055612 Nov 14, 2025
53ac34d
Add missing licences
at055612 Nov 14, 2025
5ad4f0c
Add test assert
at055612 Nov 14, 2025
a0503d3
Add TxnDeprecatedTest for more coverage
at055612 Nov 17, 2025
29d5ba2
Auto format
at055612 Nov 17, 2025
1312e10
Add tests for XxxFlags.isSet
at055612 Nov 17, 2025
0216c92
Add more test coverage
at055612 Nov 17, 2025
8b60f29
Change FlagSet args to be requireNonNull
at055612 Nov 17, 2025
e53956d
Add requireNonNull checks to Dbi
at055612 Nov 17, 2025
654a5bc
Add more coverage
at055612 Nov 17, 2025
850c4e2
Add DirectBufferProxyTest
at055612 Nov 17, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,4 @@ dependency-reduced-pom.xml
gpg-sign.json
mvn-sync.json
secrets.tar
lmdb
pom.xml.versionsBackup
8 changes: 1 addition & 7 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
<agrona.version>1.22.0</agrona.version>
<assertj.version>3.27.6</assertj.version>
<buildnumber-maven-plugin.version>3.2.1</buildnumber-maven-plugin.version>
<byteunits.version>0.9.1</byteunits.version>
<central-publishing-maven-plugin.version>0.9.0</central-publishing-maven-plugin.version>
<fmt-maven-plugin.version>2.29</fmt-maven-plugin.version>
<google-java-format.version>1.28.0</google-java-format.version>
Expand Down Expand Up @@ -85,12 +84,6 @@
<version>${guava.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>com.jakewharton.byteunits</groupId>
<artifactId>byteunits</artifactId>
<version>${byteunits.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-buffer</artifactId>
Expand Down Expand Up @@ -146,6 +139,7 @@
<excludes>
<exclude>LICENSE.txt</exclude>
<exclude>**/*.md</exclude>
<exclude>**/*.csv</exclude>
<exclude>lmdb/**</exclude>
<exclude>licenses/**</exclude>
</excludes>
Expand Down
250 changes: 250 additions & 0 deletions src/main/java/org/lmdbjava/AbstractFlagSet.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,250 @@
/*
* Copyright © 2016-2025 The LmdbJava Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.lmdbjava;

import java.util.Collection;
import java.util.Collections;
import java.util.EnumSet;
import java.util.Iterator;
import java.util.Objects;
import java.util.Set;
import java.util.function.Function;
import java.util.function.Supplier;

/**
* Encapsulates an immutable set of flags and the associated bit mask for the flags in the set.
*
* @param <T> The type of the flags in this set. Must extend {@link MaskedFlag} and {@link Enum<T>}.
*/
abstract class AbstractFlagSet<T extends Enum<T> & MaskedFlag> implements FlagSet<T> {

private final Set<T> flags;
private final int mask;

protected AbstractFlagSet(final EnumSet<T> flags) {
Objects.requireNonNull(flags);
this.mask = MaskedFlag.mask(flags);
this.flags = Collections.unmodifiableSet(Objects.requireNonNull(flags));
}

@Override
public int getMask() {
return mask;
}

@Override
public Set<T> getFlags() {
return flags;
}

@Override
public boolean isSet(final T flag) {
// Probably cheaper to compare the masks than to use EnumSet.contains()
return flag != null && MaskedFlag.isSet(mask, flag);
}

/**
* @return The number of flags in this set.
*/
@Override
public int size() {
return flags.size();
}

/**
* @return True if this set is empty.
*/
@Override
public boolean isEmpty() {
return flags.isEmpty();
}

/**
* @return The {@link Iterator} for this set.
*/
@Override
public Iterator<T> iterator() {
return flags.iterator();
}

@Override
public String toString() {
return FlagSet.asString(this);
}

static class AbstractEmptyFlagSet<T extends MaskedFlag> implements FlagSet<T> {

@Override
public int getMask() {
return MaskedFlag.EMPTY_MASK;
}

@Override
public Set<T> getFlags() {
return Collections.emptySet();
}

@Override
public boolean isSet(final T flag) {
return false;
}

@Override
public boolean areAnySet(final FlagSet<T> flags) {
return false;
}

@Override
public int size() {
return 0;
}

@Override
public boolean isEmpty() {
return true;
}

@Override
public Iterator<T> iterator() {
return Collections.emptyIterator();
}

@Override
public String toString() {
return FlagSet.asString(this);
}
}

/**
* A builder for creating a {@link AbstractFlagSet}.
*
* @param <E> The type of flag to be held in the {@link AbstractFlagSet}
* @param <S> The type of the {@link AbstractFlagSet} implementation.
*/
public static final class Builder<E extends Enum<E> & MaskedFlag, S extends FlagSet<E>> {

final Class<E> type;
final EnumSet<E> enumSet;
final Function<EnumSet<E>, S> constructor;
final Function<E, S> singletonSetConstructor;
final Supplier<S> emptySetSupplier;

Builder(
final Class<E> type,
final Function<EnumSet<E>, S> constructor,
final Function<E, S> singletonSetConstructor,
final Supplier<S> emptySetSupplier) {
this.type = type;
this.enumSet = EnumSet.noneOf(type);
this.constructor = Objects.requireNonNull(constructor);
this.singletonSetConstructor = Objects.requireNonNull(singletonSetConstructor);
this.emptySetSupplier = Objects.requireNonNull(emptySetSupplier);
}

/**
* Replaces any flags already set in the builder with the contents of the passed flags {@link
* Collection}
*
* @param flags The flags to set in the builder.
* @return this builder instance.
*/
public Builder<E, S> setFlags(final Collection<E> flags) {
clear();
if (flags != null) {
for (E flag : flags) {
if (flag != null) {
enumSet.add(flag);
}
}
}
return this;
}

/**
* Replaces any flags already set in the builder with the passed flags.
*
* @param flags The flags to set in the builder.
* @return this builder instance.
*/
@SafeVarargs
public final Builder<E, S> setFlags(final E... flags) {
clear();
if (flags != null) {
for (E flag : flags) {
if (flag != null) {
if (!type.equals(flag.getClass())) {
throw new IllegalArgumentException("Unexpected type " + flag.getClass());
}
enumSet.add(flag);
}
}
}
return this;
}

/**
* Adds a single flag in the builder.
*
* @param flag The flag to set in the builder.
* @return this builder instance.
*/
public Builder<E, S> addFlag(final E flag) {
if (flag != null) {
enumSet.add(flag);
}
return this;
}

/**
* Adds multiple flag in the builder.
*
* @param flags The flags to set in the builder.
* @return this builder instance.
*/
public Builder<E, S> addFlags(final Collection<E> flags) {
if (flags != null) {
enumSet.addAll(flags);
}
return this;
}

/**
* Clears any flags already set in this {@link Builder}
*
* @return this builder instance.
*/
public Builder<E, S> clear() {
enumSet.clear();
return this;
}

/**
* Build the {@link DbiFlagSet}
*
* @return A
*/
public S build() {
final int size = enumSet.size();
if (size == 0) {
return emptySetSupplier.get();
} else if (size == 1) {
return singletonSetConstructor.apply(enumSet.stream().findFirst().get());
} else {
return constructor.apply(enumSet);
}
}
}
}
37 changes: 17 additions & 20 deletions src/main/java/org/lmdbjava/BufferProxy.java
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,6 @@
package org.lmdbjava;

import static java.lang.Long.BYTES;
import static org.lmdbjava.DbiFlags.MDB_INTEGERKEY;
import static org.lmdbjava.DbiFlags.MDB_UNSIGNEDKEY;
import static org.lmdbjava.MaskedFlag.isSet;
import static org.lmdbjava.MaskedFlag.mask;

import java.util.Comparator;
import jnr.ffi.Pointer;
Expand Down Expand Up @@ -75,30 +71,22 @@ protected BufferProxy() {}
* <p>The provided comparator must strictly match the lexicographical order of keys in the native
* LMDB database.
*
* @param flags for the database
* @param dbiFlagSet The {@link DbiFlags} set for the database.
* @return a comparator that can be used (never null)
*/
protected Comparator<T> getComparator(DbiFlags... flags) {
final int intFlag = mask(flags);

return isSet(intFlag, MDB_INTEGERKEY) || isSet(intFlag, MDB_UNSIGNEDKEY)
? getUnsignedComparator()
: getSignedComparator();
}
public abstract Comparator<T> getComparator(final DbiFlagSet dbiFlagSet);

/**
* Get a suitable default {@link Comparator} to compare numeric key values as signed.
* Get a suitable default {@link Comparator}
*
* @return a comparator that can be used (never null)
*/
protected abstract Comparator<T> getSignedComparator();

/**
* Get a suitable default {@link Comparator} to compare numeric key values as unsigned.
* <p>The provided comparator must strictly match the lexicographical order of keys in the native
* LMDB database.
*
* @return a comparator that can be used (never null)
*/
protected abstract Comparator<T> getUnsignedComparator();
public Comparator<T> getComparator() {
return getComparator(DbiFlagSet.empty());
}

/**
* Called when the <code>MDB_val</code> should be set to reflect the passed buffer. This buffer
Expand Down Expand Up @@ -138,4 +126,13 @@ protected Comparator<T> getComparator(DbiFlags... flags) {
final KeyVal<T> keyVal() {
return new KeyVal<>(this);
}

/**
* Create a new {@link Key} to hold pointers for this buffer proxy.
*
* @return a non-null key holder
*/
final Key<T> key() {
return new Key<>(this);
}
}
Loading
Loading