Repository navigation
Add per-network super-admin scoping to REST sites controller - #8
Merged
Conversation
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
is_super_admin( $user_id, $network_id ),get_super_admins( $network_id )) so super-admin status can be checked against a specific network, not just the current one.wp/v2/sitesREST controller's permission checks (check_network_ids_exist()/check_network_access()) for the list, single-item, create, and update routes, so a network's ownsite_adminsoption can scope access to sites on that network.Test plan
npm run test:php -- --filter WP_Test_REST_Sites_Controller(single-site)npm run test:php -- -c tests/phpunit/multisite.xml --filter WP_Test_REST_Sites_Controller(multisite)🤖 Generated with Claude Code