add skill to aid developers in addressing pr comments#915
Open
balos1 wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I started making this while handling PR #854. I think it would have been smoother if I had thought through the skill beforehand. Here is what I suggest:
1.After received PR comments, go through each one and leave a reply which an agent could use to decide if the comment should be addressed and how. If the comment you are replying to is a suggestion that can just be accepted, then just reply something like "LGTM" or "OK". If it is open ended, add some detail about how to address it. If you don't want the suggestion to be implemented, then say something along those lines. You dont have to reply to every comment, but it does help steer the agent.
2. Use the skill in your agent. In codex, you do something like
.agents/scratchfor explanations on what the agent didgit diff origin/<branch>..HEAD