This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[[ Scriptify ]] Scriptify environment stack - #5599
Merged
Merged
Conversation
|
@montegoulding, thanks for your PR! By analyzing the history of the files in this pull request, we identified @livecodefraser and @livecodeali to be potential reviewers. |
Contributor
|
Just a thought here - would it be better to have: As the structure? It keeps the scripts which are related to environment.rev all together. |
Contributor
Author
|
OK |
montegoulding
force-pushed
the
scriptifyenv
branch
from
June 14, 2017 11:09
2dd7284 to
2a0eec3
Compare
This patch moves all scripts in the environment stack longer than 10 words to script only behavior stacks and replaces the update libURL target with a descriptify target which adds libURL and the behavior stacks as substacks of the environment stack.
montegoulding
force-pushed
the
scriptifyenv
branch
from
June 23, 2017 03:53
2a0eec3 to
6ec599b
Compare
Contributor
Author
|
This is just a straight rebase onto develop-8.1 after checking there was no diffs on the Environment.rev between develop and develop-8.1 |
Member
|
@livecode-vulcan review ok 6ec599b |
Contributor
|
💙 review by @livecodeali ok 6ec599b |
livecode-vulcan
added a commit
that referenced
this pull request
Jun 23, 2017
[[ Scriptify ]] Scriptify environment stack This patch moves all scripts in the environment stack longer than 10 words to script only behavior stacks and replaces the update libURL target with a descriptify target which adds libURL and the behavior stacks as substacks of the environment stack.
Contributor
|
😎 test success 6ec599b
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch moves all scripts in the environment stack longer than 10 words to
script only behavior stacks and replaces the update libURL target with a
descriptify target which adds libURL and the behavior stacks as substacks
of the environment stack.