Update init so that sys.executable points to python#4
Merged
jonatanklosko merged 1 commit intomainfrom Feb 21, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running hf/transformers, during the first time a model is downloaded, I noticed a long message with BEAM executable usage. It turns out that there is a Python module that may spawn another Python OS process when certain shared resources are opened, such as shared memory, semaphores, to make sure the resources are never leaked (ref). The issue is that it tries to spawn
sys.executable(effectivelyargv[0]), which points to the BEAM executable. This PR fixes it, such that it points to a Python executable.This introduces a breaking change to
Pythonx.init, and I decided to remove it from the API altogether, until there is an actual use case for it. In practice, I don't see a good reason no to usePythonx.uv_init, especially that getting the paths correctly across OSes can be tricky.