Repository navigation
Page Optimize: delay scripts that already have defer in Delayed mode - #1070
Merged
hi-hai merged 1 commit intoOct 16, 2026
Merged
Conversation
With Load JS Deferred set to Delayed and JS Combine off, _js_defer() left any script that already had a defer attribute untouched. WordPress prints defer for scripts registered with the defer strategy, which WooCommerce uses for woocommerce.js, add-to-cart, cart-fragments, js-cookie and blockui. Those files then ran natively at DOMContentLoaded while their inline data (woocommerce-js-extra, wc-add-to-cart-js-extra) waited for user interaction, so woocommerce.js failed with "woocommerce_params is not defined". In Delayed mode such scripts now drop defer and join the delay queue, which runs them in document order after their inline data. Deferred mode still leaves an existing defer as is, and data-no-defer and the defer exclude list keep working.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Load JS Deferred set to Delayed and JS Combine off, _js_defer() left any script that already had a defer attribute untouched. WordPress prints defer for scripts registered with the defer strategy, which WooCommerce uses for woocommerce.js, add-to-cart, cart-fragments, js-cookie and blockui. Those files then ran natively at DOMContentLoaded while their inline data (woocommerce-js-extra, wc-add-to-cart-js-extra) waited for user interaction, so woocommerce.js failed with "woocommerce_params is not defined".
In Delayed mode such scripts now drop defer and join the delay queue, which runs them in document order after their inline data. Deferred mode still leaves an existing defer as is, and data-no-defer and the defer exclude list keep working.