Repository navigation
Htaccess: remove LiteSpeed marker blocks on deactivation - #1068
Open
timotei-litespeed wants to merge 1 commit into
Open
timotei-litespeed wants to merge 1 commit into
timotei-litespeed wants to merge 1 commit into
Conversation
…eaving them empty Deactivation cleared the LSCACHE and NON_LSCACHE blocks by writing an empty insertion, so "# BEGIN/END LSCACHE" and "# BEGIN/END NON_LSCACHE" stayed in .htaccess, and were even prepended when the markers were already gone. clear_rules() now removes every copy of both blocks, markers included, in one write and keeps the rest of the file as is. It skips the backup and the write when there is nothing to remove, and never creates a missing .htaccess.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of leaving them empty
Deactivation cleared the LSCACHE and NON_LSCACHE blocks by writing an empty insertion, so "# BEGIN/END LSCACHE" and "# BEGIN/END NON_LSCACHE" stayed in .htaccess, and were even prepended when the markers were already gone.
clear_rules() now removes every copy of both blocks, markers included, in one write and keeps the rest of the file as is. It skips the backup and the write when there is nothing to remove, and never creates a missing .htaccess.