New RNN-RBM tutorial - #14
Conversation
|
You should use our coding standard for our tutorial. Many of them can be fixed automatically with autopep8 -i file.py Then test it sometimes, it add extra new line that break code, so review the change. Also, what changes did you do to the python midi? We need to find another to distribute that code. For the download music files, we have a file data/download.sh that should download all dataset. Can you add your there and modify the path to access it? I copied your data file in the same directory as the other datasets: http://www.iro.umontreal.ca/~lisa/deep/data/mnist/Nottingham.zip that way we have less risk of loosing/breaking it. |
|
Coding style and download location are now standard (verified using pep8). Python MIDI: I added capability to read and write MIDI files into piano-rolls directly. It is only 25.4 kB so pretty negligible compared to the dataset size. You can also store it under http://www.iro.umontreal.ca/~lisa/deep/data/ or on another host. |
|
The problem isn't the download or the size. The problem is that there is a name colission between them. I see two solution. You get your change integrated into Python MIDI, or we put it elsewhere. We do not want a tutorial to depend of a special fork. Can you submit your path to the authors and see their response? If it take too much time for the inclusion of this change and the release of there next version, we should store it inside a file in the DLT until that time. |
New RNN-RBM tutorial
New RNN-RBM tutorial Former-commit-id: f5a295d
No description provided.