Skip to content

New RNN-RBM tutorial - #14

Merged
nouiz merged 9 commits into
lisa-lab:masterfrom
boulanni:master
Feb 8, 2013
Merged

New RNN-RBM tutorial#14
nouiz merged 9 commits into
lisa-lab:masterfrom
boulanni:master

Conversation

@boulanni

@boulanni boulanni commented Jan 6, 2013

Copy link
Copy Markdown
Contributor

No description provided.

@nouiz

nouiz commented Jan 23, 2013

Copy link
Copy Markdown
Member

You should use our coding standard for our tutorial. Many of them can be fixed automatically with

autopep8 -i file.py

Then test it sometimes, it add extra new line that break code, so review the change.

Also, what changes did you do to the python midi? We need to find another to distribute that code.

For the download music files, we have a file data/download.sh that should download all dataset. Can you add your there and modify the path to access it? I copied your data file in the same directory as the other datasets:

http://www.iro.umontreal.ca/~lisa/deep/data/mnist/Nottingham.zip

that way we have less risk of loosing/breaking it.

@boulanni

Copy link
Copy Markdown
Contributor Author

Coding style and download location are now standard (verified using pep8).

Python MIDI: I added capability to read and write MIDI files into piano-rolls directly. It is only 25.4 kB so pretty negligible compared to the dataset size. You can also store it under http://www.iro.umontreal.ca/~lisa/deep/data/ or on another host.

@nouiz

nouiz commented Jan 29, 2013

Copy link
Copy Markdown
Member

The problem isn't the download or the size. The problem is that there is a name colission between them. I see two solution. You get your change integrated into Python MIDI, or we put it elsewhere. We do not want a tutorial to depend of a special fork.

Can you submit your path to the authors and see their response? If it take too much time for the inclusion of this change and the release of there next version, we should store it inside a file in the DLT until that time.

nouiz added a commit that referenced this pull request Feb 8, 2013
@nouiz
nouiz merged commit 4449866 into lisa-lab:master Feb 8, 2013
taneishi pushed a commit to taneishi/DBN that referenced this pull request Nov 28, 2019
taneishi pushed a commit to taneishi/DBN that referenced this pull request Feb 13, 2020
New RNN-RBM tutorial

Former-commit-id: f5a295d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants